Change 'check_install' to take an list of parameters instead of a string.

Review Request #5095 — Created Dec. 11, 2013 and submitted — Latest diff uploaded

Information

RBTools
master

Reviewers

Change check_install to take an list of parameters instead of a string.

The check_install method is used to check to see if various command-line
tools we use are present. This method used to take a string and split it on
spaces to get a list of parameters. This seemed an ugly and error-prone way of
breaking things up, so I've changed it to take in a list of parameters instead,
which are passed directly into Popen.

  • Ran unit tests.
  • Smoke tested rbt.
rbtools/clients/bazaar.py
rbtools/clients/clearcase.py
rbtools/clients/cvs.py
rbtools/clients/git.py
rbtools/clients/mercurial.py
rbtools/clients/perforce.py
rbtools/clients/plastic.py
rbtools/clients/svn.py
rbtools/utils/checks.py
rbtools/utils/tests.py
Loading...