• 
      

    Fix post -u bug that uses the incorrect summary.

    Review Request #5041 — Created Dec. 2, 2013 and submitted

    Information

    RBTools
    master

    Reviewers

    Fix post -u bug that uses the incorrect summary.

    If a draft exists for the review request, post -u should use the draft’s
    summary and description instead of the review request's summary and description
    to detect and prompt for the review request to update. This patch fixes the
    issue where post -u would always use the review request’s summary and
    description even if a draft exists.

    Tested with published and draft review requests.
    Unit tests passed.

    Description From Last Updated

    Can you change the formatting a little bit to make the grouping clearer? summary_pair = ( self.get_draft_or_current_value( 'summary', review_request), summary)

    daviddavid
    david
    1. 
        
    2. rbtools/commands/post.py (Diff revision 1)
       
       
       
       
       
      Show all issues

      Can you change the formatting a little bit to make the grouping clearer?

      summary_pair = (
          self.get_draft_or_current_value(
              'summary', review_request),
          summary)
      
    3. 
        
    ED
    david
    1. Ship It!
    2. 
        
    ED
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (26ecc73). Thanks!