Properly handle incorrect revisions in the github get_change() implementation.
Review Request #5015 — Created Nov. 19, 2013 and submitted
Properly handle incorrect revisions in the github
get_change()
implementation.The
get_change()
implementation in the GitHub hosting service was letting a
bareException
through in its failure case, which I think only really happens
when GitHub's API is having problems. This meant that the API would return a
500 and we'd get a traceback in our email. I've changed it to catchException
and re-raise asSCMError
, which is caught byReviewRequestResource.create()
.
Ran unit tests.
Description | From | Last Updated |
---|---|---|
Will this do the right thing? Don't we need to convert to a string? |
chipx86 |