• 
      

    Properly handle incorrect revisions in the github get_change() implementation.

    Review Request #5015 — Created Nov. 19, 2013 and submitted

    Information

    Review Board
    master

    Reviewers

    Properly handle incorrect revisions in the github get_change() implementation.

    The get_change() implementation in the GitHub hosting service was letting a
    bare Exception through in its failure case, which I think only really happens
    when GitHub's API is having problems. This meant that the API would return a
    500 and we'd get a traceback in our email. I've changed it to catch Exception
    and re-raise as SCMError, which is caught by ReviewRequestResource.create().

    Ran unit tests.

    Description From Last Updated

    Will this do the right thing? Don't we need to convert to a string?

    chipx86chipx86
    chipx86
    1. Mind adding a unit test for this?

    2. reviewboard/hostingsvcs/github.py (Diff revision 1)
       
       
       
      Show all issues

      Will this do the right thing? Don't we need to convert to a string?

    3. 
        
    david
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (6d9baa1).