Summary

Fix ETags-based caching.

Review Request #5004 — Created Nov. 18, 2013 and submitted Nov. 18, 2013, 4:06 p.m. — Latest diff uploaded Nov. 18, 2013, 3:28 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-0.7.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

Fix ETags-based caching.

Our ETags-based caching has apparently been broken for a while. We've
been accessing an older form of the keys and not the "newer" normalized
form. This meant that our caching for review requests and other pages
weren't as effective.

Testing Done

Tested with a couple review requests. Verified that we could get the

If-None-Match header value in the request, compare against a review

request's ETag, and return a 304 Not Modified.