Summary

Perform unicode migration for reviewboard/reviews

Review Request #4966 — Created Nov. 15, 2013 and submitted Nov. 16, 2013, 2:11 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Perform unicode migration for reviewboard/reviews
This change represents an audit of all of our string literals to make sure that

bytestrings are annotated with a leading 'b', and then adds

"from __future__ import unicode_literals" to the beginning of every non-empty

file. This also includes some changes to use six.text_type for python 2/3

compatibility, and changes some file opens to use 'with'.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Not totally sure why we had this line, but can we just append summary now?	chipx86	Nov. 15, 2013, 6:30 p.m.

Change Summary:: Paste-o
Summary:: Perform unicode migration for reviewboard/admin
Perform unicode migration for reviewboard/reviews
Description:: ~
Perform unicode migration for reviewboard/admin
~
Perform unicode migration for reviewboard/reviews

This change represents an audit of all of our string literals to make sure that
bytestrings are annotated with a leading 'b', and then adds
"from __future__ import unicode_literals" to the beginning of every non-empty
file. This also includes some changes to use six.text_type for python 2/3
compatibility, and changes some file opens to use 'with'.

reviewboard/reviews/datagrids.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Not totally sure why we had this line, but can we just append summary now?
```

Diff:

Revision 2 (+241 -154)

Show changes

	reviewboard/reviews/admin.py
	reviewboard/reviews/context.py
	reviewboard/reviews/datagrids.py
	reviewboard/reviews/errors.py
	reviewboard/reviews/forms.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/markdown_utils.py
	reviewboard/reviews/models.py
	34 more

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (c90705b).

~		Perform unicode migration for reviewboard/admin
	~	Perform unicode migration for reviewboard/reviews

		This change represents an audit of all of our string literals to make sure that
		bytestrings are annotated with a leading 'b', and then adds
		"`from __future__ import unicode_literals`" to the beginning of every non-empty
		file. This also includes some changes to use `six.text_type` for python 2/3
		compatibility, and changes some file opens to use 'with'.