Summary

Perform unicode migration for reviewboard/admin

Review Request #4958 — Created Nov. 15, 2013 and submitted Nov. 15, 2013, 11:15 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Perform unicode migration for reviewboard/admin
This change represents an audit of all of our string literals to make sure that

bytestrings are annotated with a leading 'b', and then adds

"from __future__ import unicode_literals" to the beginning of every non-empty

file. This also includes some changes to handle string/byte types when

communicating with memcached, some changes to use six.text_type for python 2/3

compatibility, and marking some additional strings for translation.

Testing Done


Ran unit tests
Smoke tested admin

Issues

Description	From	Last Updated
Here too.	chipx86	Nov. 15, 2013, 6:25 p.m.
Probably no point in actually doing six.text_type() here, since the format strings will take care of it.	chipx86	Nov. 15, 2013, 6:27 p.m.
Same here.	chipx86	Nov. 15, 2013, 6:28 p.m.

reviewboard/admin/management/commands/loaddb.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Here too.
```

reviewboard/admin/siteconfig.py (Diff revision 1)

I remember the Amazon support being pretty finicky. Are we use that six.text_type will always satisfy its requirements?

david Nov. 15, 2013, 6:28 p.m.

Reading through django-storages and boto code, I don't see any reason why the unicode type wouldn't work. I think this was an issue in the pre-boto implementation.

reviewboard/admin/widgets.py (Diff revision 1)

The issue has been resolved. Show all issues

Probably no point in actually doing six.text_type() here, since the format strings will take care of it.

reviewboard/admin/widgets.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here.
```

Diff:

Revision 2 (+69 -28)

Show changes

	reviewboard/admin/__init__.py
	reviewboard/admin/cache_stats.py
	reviewboard/admin/checks.py
	reviewboard/admin/context_processors.py
	reviewboard/admin/forms.py
	reviewboard/admin/middleware.py
	reviewboard/admin/signals.py
	reviewboard/admin/siteconfig.py
	13 more

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (618f825).