Summary

Abstract away some types

Review Request #4906 — Created Nov. 5, 2013 and submitted Nov. 6, 2013, 11:23 p.m.

Information

Owner

david

Repository

Djblets

Branch

master

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

Abstract away some types

String and integer types have changed in python 3. In 2.x, the str type is a
string of bytes, and the unicode type is a string of text. In 3.x, the
bytes type has replaced the old str, and str has replaced unicode. The
six library has abstractions for these that we can use while we're trying to
support both.

Additionally, 3.x has merged the int and long types, so there's a similar
abstraction for that.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Do we really need it in this case? Wouldn't str() do the right thing in either case here when we're …	chipx86	Nov. 6, 2013, 5:36 p.m.

djblets/util/templatetags/djblets_js.py (Diff revision 1)

The issue has been dropped. Show all issues

Do we really need it in this case? Wouldn't str() do the right thing in either case here when we're using string formatters?

I thought text_type was more useful when doing isinstance and such.

I admit ignorance in a lot of this.

david Nov. 6, 2013, 5:36 p.m.

Given that we were explicitly casting to unicode, I think I'd rather use the six type. It's str in python 3 and unicode in python 2, which duplicates what we were doing here already.

Ship it!

```
Ship It!
```

Status:: Completed