• 
      
    Fish Trophy

    chipx86 got a fish trophy!

    Fish Trophy

    Factor in the "Blocks" list for the review request cache key.

    Review Request #4884 — Created Nov. 3, 2013 and submitted — Latest diff uploaded

    Information

    Review Board
    release-1.7.x

    Reviewers

    Factor in the "Blocks" list for the review request cache key.

    When setting the Depends On field of a review request, the listed
    review requests won't have their caches invalidated. Navigating to those
    review requests won't show any entries for "Blocks" until you
    shift-reload.

    We now include the Blocks list as part of the ETag for caching the page.

    Opened two review requests. Set one to depend on the other. Reloaded the
    other. It re-fetched the page.

    Prior to this change, it would show stale content in that scenario.