Improve diff pagination a little bit.

Review Request #4856 — Created Oct. 28, 2013 and submitted

Information

Review Board
master

Reviewers

Improve diff pagination a little bit.

This doesn't change pagination in a wild way, it just fixes it to not be super
weird. During the diff index changes, the pagination links at the top of the
diffs disappeared, leaving it so the only one was at the bottom. This was a
rude surprise when I slogged through a big review only to discover that there
were two or three more pages! I've restored the pagination links at the top,
which means there's one set of links after the diff index and one at the very
bottom of the page.

I also changed it so switching pages will operate without a reload. This makes
it very smooth to navigate around.

Switched around to a bunch of different revisions and interdiff revisions with
multiple pages. Made sure that switching pages always went to the right place,
and that switching to new revisions always loaded the first page of the
new revision.

Description From Last Updated

These can be combined.

chipx86chipx86

How/where is this used?

chipx86chipx86
chipx86
  1. 
      
  2. Do we need to use <%- for the title? I noticed a couple lines down that you moved away from escaping here, but wasn't sure why.

    1. I was seeing "Page%201" in my tooltip but I think I got a little overzealous.

  3. Show all issues

    These can be combined.

  4. reviewboard/webapi/resources/diff_context.py (Diff revision 1)
     
     
     
     
     
    Show all issues

    How/where is this used?

    1. DiffViewerView.get_context_data will pull this out of request.GET to choose the page number. It just needs to be listed here so that the webapi layer will pass it through.

  5. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to master (3a35b6a).