Clean up the git diff call a bit in make_diff

Review Request #4823 — Created Oct. 21, 2013 and submitted

Information

RBTools
master

Reviewers

Clean up the git diff call a little bit

In particular -M (--find-renames) and --no-renames should be
mutually exclusive and the revision range should come last in
the diff command before any options terminating dashes (--)
and paths. git doesn't enforce this today, but it could
tomorrow..

Sponsored-by: Zonar Systems, Inc
Signed-off-by: Garrett Cooper yanegomi@gmail.com

garrett.cooper@ZL00757 ~/git/rbtools
$ rbt post --submit-as yaneurabeya
Review request #4823 posted.

http://reviews.reviewboard.org/r/4823/

david
  1. Ship It!
  2. 
      
YA
Review request changed
Status:
Completed
Change Summary:
Pushed to release-0.5.x (c984aa1). Thanks!