• 
      

    Remove positional and unnecessary arguments on get_queryset calls.

    Review Request #4817 — Created Oct. 21, 2013 and submitted

    Information

    Review Board
    master

    Reviewers

    Remove positional and unnecessary arguments on get_queryset calls.

    A number of API handlers were passing positional arguments to
    get_queryset, such as the review_request_id. Most of these arguments
    weren't even necessary to explicitly pull out of kwargs and pass, since
    we're passing kwargs directly.

    The problem with positional arguments in these calls is that things get
    messed up if a get_queryset or get_object implementation wants to
    declare some other parameter before args and kwargs. The wrong value
    would get passed for the wrong argument.

    Unit tests pass.

    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed