3116: Interrupting post-review/rbt post throws a KeyboardInterrupt exception

yane****@gmai***** (Google Code) (Is this you? Claim this profile.)
Jan. 31, 2014
What version are you running?

0.5.2-dev

What steps will reproduce the problem?

1. post-review --diff-filename /dev/null --username foobar
2. Hit ^C at Password: prompt

What is the expected output? What do you see instead?

No exceptions should be thrown. Instead I see a nasty traceback stack:

==> HTTP Authentication Required
Enter authorization information for "Web API" at reviews.reviewboard.org
Password: Traceback (most recent call last):
  File "/usr/bin/post-review", line 8, in <module>
    load_entry_point('RBTools==0.5.2.dev', 'console_scripts', 'post-review')()
  File "/usr/lib/python2.7/site-packages/RBTools-0.5.2.dev-py2.7.egg/rbtools/postreview.py", line 1314, in main
    server.load_capabilities()
  File "/usr/lib/python2.7/site-packages/RBTools-0.5.2.dev-py2.7.egg/rbtools/postreview.py", line 274, in load_capabilities
    info = self.api_get('api/info/')
  File "/usr/lib/python2.7/site-packages/RBTools-0.5.2.dev-py2.7.egg/rbtools/postreview.py", line 705, in api_get
    return self.process_json(self.http_get(path))
  File "/usr/lib/python2.7/site-packages/RBTools-0.5.2.dev-py2.7.egg/rbtools/postreview.py", line 675, in http_get
    rsp = urllib2.urlopen(url).read()
  File "/usr/lib/python2.7/urllib2.py", line 127, in urlopen
    return _opener.open(url, data, timeout)
  File "/usr/lib/python2.7/urllib2.py", line 402, in open
    req = meth(req)
  File "/usr/lib/python2.7/site-packages/RBTools-0.5.2.dev-py2.7.egg/rbtools/postreview.py", line 80, in http_request
    self.password_mgr.find_user_password('Web API', self.url)
  File "/usr/lib/python2.7/site-packages/RBTools-0.5.2.dev-py2.7.egg/rbtools/postreview.py", line 180, in find_user_password
    self.rb_pass = getpass.getpass('Password: ')
  File "/usr/lib/python2.7/getpass.py", line 71, in unix_getpass
    passwd = _raw_input(prompt, stream, input=input)
  File "/usr/lib/python2.7/getpass.py", line 133, in _raw_input
    line = input.readline()
KeyboardInterrupt

What operating system are you using? What browser?

$ uname -a
CYGWIN_NT-6.1 ZL00757 1.7.25(0.270/5/3) 2013-08-31 20:37 x86_64 Cygwin
david
#1 david
  • +Component-RBTools
david
#2 david
This has since been fixed.
  • +Fixed