Summary

Don't trigger revisionSelected from the revision selector when there's no change.

Review Request #4746 — Created Oct. 14, 2013 and submitted Oct. 14, 2013, 3:32 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Don't trigger revisionSelected from the revision selector when there's no change.

Dragging a handle on the revision selector would cause a reload, even if it was
dropped back on the place that it started. This change guards it, and fixes
some logic to copy the values array instead of referencing it.

Testing Done

Checked that changing the revision selector would trigger a load, except when
the handle was dropped back on its previous location.

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
Ignored Files:
reviewboard/static/rb/js/diffviewer/views/diffRevisionSelectorView.js

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
Ignored Files:
reviewboard/static/rb/js/diffviewer/views/diffRevisionSelectorView.js

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (dc4f313).