• 
      

    Convert dashboard to be a generic view

    Review Request #47 — Created June 4, 2007 and submitted — Latest diff uploaded

    Information

    Review Board SVN (deprecated)
    trunk
    75

    Reviewers

    We weren't using generic views in the dashboard because there's
    a bug in Q objects that was preventing us from creating a query
    for the "all incoming reviews" view.  We hacked around this by
    doing the OR+distinct step ourselves using lists.
    
    It turns out that with just a little coaxing, django's generic
    object_list view can be used with a list instead of a QuerySet.
    This change does that, and makes the dashboard into a simple
    superset of object_list.  The major benefit of this is that we
    get pagination basically for free.
    Set pagination interval very low (for my meager number of
    review requests in my test server) and tried a couple
    different views in the dashboard.