Summary

Convert dashboard to be a generic view

Review Request #47 — Created June 3, 2007 and submitted

Information

Owner

david

Repository

Review Board SVN (deprecated)

Branch

trunk

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

We weren't using generic views in the dashboard because there's
a bug in Q objects that was preventing us from creating a query
for the "all incoming reviews" view.  We hacked around this by
doing the OR+distinct step ourselves using lists.

It turns out that with just a little coaxing, django's generic
object_list view can be used with a list instead of a QuerySet.
This change does that, and makes the dashboard into a simple
superset of object_list.  The major benefit of this is that we
get pagination basically for free.

Testing Done

Set pagination interval very low (for my meager number of
review requests in my test server) and tried a couple
different views in the dashboard.

```
Awesome :) Only a couple things.
```

trunk/reviewboard/reviews/views.py (Diff revision 1)

Cute hack. I feel we should move it out of here, though, as it could be useful later.

david June 3, 2007, 6:19 p.m.

Eh, I'd rather wait.  What we're doing in the dashboard for the incoming
view is pretty bad from a database performance standpoint (we're really
only saved from being totally crunked up by the fact that the db is
filtering for status='P' here).  If we really end up having cause to do
this same kind of hack elsewhere, we can move it to a common place.

chipx86 June 4, 2007, 4:36 a.m.
```
Fair enough.
```

trunk/reviewboard/templates/reviews/dashboard.html (Diff revision 1)

Can we change object_list to review_request_list? We can name this by setting template_object_name to "review_request" when creating the view.

david June 4, 2007, 2:55 a.m.
```
Done.
```

trunk/reviewboard/templates/reviews/dashboard.html (Diff revision 1)

There's a group= parameter that's passed to the page when looking at review requests for a certain group. We need to pass this as well. We can probably just unconditionally set it, since it'll be empty if we're not in group mode, but it would look nicer to make it conditional.

david June 4, 2007, 2:56 a.m.

Done.  I don't think it's too terrible if it's always there,
since it'll only be in the URL if they're looking at pages
other than the first, which should hopefully never happen.

chipx86 June 4, 2007, 4:36 a.m.
```
Yeah. It's fine to leave it.
```

Ship it!

```
Looks good. Ship it.
```