2252: Revision/interdiff selection UI is confusing

ow**@humblebu******** (Google Code) (Is this you? Claim this profile.)
Oct. 14, 2013 
What version are you running?
1.5.5

What's the URL of the page containing the problem?
Any review request with more than one diff revision

What steps will reproduce the problem?
View the main page for the given review

What is the expected output? What do you see instead?

I would expect to see:
Diff revision 2 (Latest)
Jump to revision:	[1] [2]
Changes between r2 and:	[trunk] [1]

This is what I see:
Diff revision 2 (Latest)
Jump to revision:	[1] [2]
Changes between r2 and:	[1] [2]

If I'm viewing revision 2, then I would expect to be able to see changes between trunk and r2 or changes between r1 and r2. Why is there a button for changes between r2 and r2? That doesn't make sense.


What operating system are you using? What browser?
Mac OS X 10.6.8, Chrome

Please provide any additional information below.
chipx86
#1 chipx86 
These are revisions of diffs on a review request, rather than revisions within the repository. This selector allows reviewers to see what changed between versions of a diff that you've uploaded. For example, if you put up a large change, then make some additional changes to it based on reviews, and update your diff, reviewers will be able to see just those changes you've made instead of having to re-read a large diff.

The UI for the diff revisions selector will undergo a rewrite at some point, as its interaction is not great and is a hold-over from the very early days of Review Board.

If you're on r2, you shouldn't actually be able to click r2. The style on it should indicate that it's selected as one end of the revision range. Is that not happening? Is it actually clickable?

Does that clear things up?

(Love the Humble Indie Bundle, btw.)
  • +NeedInfo
  • +chipx86
#2 ow**@humblebu******** (Google Code) (Is this you? Claim this profile.) 
Nope, the r2 is not clickable... sorry I wasn't clear in my description. Glad to hear the UI will be revised at some point. I understand how it works now, but it always throws me for a loop.
david
#3 david
  • -NeedInfo
    +Confirmed
  • +Component-DiffViewer
  • -chipx86
    +-**@gmai***** (Google Code)
#4 e.t****@gmai***** (Google Code) (Is this you? Claim this profile.) 
I'd like to see changes between "trunk" and latest revision too. In this way it would be possible to aggregate commits for a task in the same review, and the reviewer would be able to see the diff for the whole task.
#5 ow**@humblebu******** (Google Code) (Is this you? Claim this profile.) 
FWIW, the way it works currently as I understand it:

"Jump to revision x" shows you diffs between revision x and trunk
"Changes between revision x and y" shows you diffs between revision x and y

It's not very intuitive, but it does let you see diffs between any two revisions including trunk.
chipx86
#6 chipx86 
Not trunk, just the base revision listed in the diff (which may be different in any particular diff revision).
#7 e.t****@gmai***** (Google Code) (Is this you? Claim this profile.) 
True. Something like "changes between r0 and r2". But we don't have r0.
david
#8 david
  • +Revision/interdiff selection UI is confusing
david
#9 david 
Fixed in master (3bb6226). You can see the new UI here: https://reviews.reviewboard.org/r/4695/
  • -Confirmed
    +Fixed