Summary

Remove some hacks and quirks from reviewboard javascript.

Review Request #4679 — Created Oct. 3, 2013 and submitted Oct. 8, 2013, 11:26 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Remove some hacks and quirks from reviewboard javascript.

This change removes a few of our hacks from the Review Board code. There's
still a few in there for IE8 and 9, which I'd like to eliminate, but I haven't
figured out how to do so in a way that won't keep relying on $.browser

Testing Done

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
Ignored Files:
reviewboard/static/rb/js/views/imageReviewableView.js
reviewboard/static/rb/js/views/commentDialogView.js
reviewboard/static/rb/js/pages/views/reviewablePageView.js

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
Ignored Files:
reviewboard/static/rb/js/views/imageReviewableView.js
reviewboard/static/rb/js/views/commentDialogView.js
reviewboard/static/rb/js/pages/views/reviewablePageView.js

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (1114158).