Add some very simple tests for the parse() methods in diffviewer models.

Review Request #4643 — Created Sept. 24, 2013 and submitted

Information

Review Board
master

Reviewers

Add some very simple tests for the parse() methods in diffviewer models.

The diff viewer has several new models that aggregate bits of data required to
build the page. This change adds unit tests for the parse() methods, which
convert the names in the webapi into javascript-style camelCase names.

Ran js-tests.

Description From Last Updated

'from settings_local import *' used; unable to detect undefined names

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    reviewboard/settings.py
    Ignored Files:
    reviewboard/static/rb/js/diffviewer/models/tests/diffRevisionModelTests.js
    reviewboard/static/rb/js/diffviewer/models/tests/diffFileModelTests.js
    reviewboard/static/rb/js/pages/models/diffViewerPageModel.js
    reviewboard/static/rb/js/diffviewer/models/diffCommentsHintModel.js
    reviewboard/static/rb/js/diffviewer/models/diffFileModel.js
    reviewboard/static/rb/js/diffviewer/models/tests/paginationModelTests.js

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    reviewboard/settings.py
    Ignored Files:
    reviewboard/static/rb/js/diffviewer/models/tests/diffRevisionModelTests.js
    reviewboard/static/rb/js/diffviewer/models/tests/diffFileModelTests.js
    reviewboard/static/rb/js/pages/models/diffViewerPageModel.js
    reviewboard/static/rb/js/diffviewer/models/diffCommentsHintModel.js
    reviewboard/static/rb/js/diffviewer/models/diffFileModel.js
    reviewboard/static/rb/js/diffviewer/models/tests/paginationModelTests.js

  2. reviewboard/settings.py (Diff revision 1)
     
     
    Show all issues

    'from settings_local import *' used; unable to detect undefined names

  3. 
      
chipx86
  1. Ship It!

  2. 
      
david
Review request changed
Status:
Completed
Change Summary:

Pushed to master (9134fbb).