Fix the subject in test_put_reviewrequestdraft_publish

 






 

 


  Review Request #4621
  —
  Created Sept. 21, 2013 and submitted 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Fix the subject in test_put_reviewrequestdraft_publish


In Django 1.5.x, the locmem email backend will trigger header validation and

generate a message ID. This means that the subject when publishing a second

draft will be "Re: ...". Our previous implementation of the assertion was

actually incorrect, but it took a while to convince myself of that.

 








  


 
 

  
Ran unit tests.

 







 









 





  








 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
Col: 80 E501 line too long (81 > 79 characters)

      		
      
       reviewbotreviewbot
      
      
       
      
     




     

      
       
       
'templatetags' imported but unused

      		
      
       reviewbotreviewbot
      
      
       
      
     


    
   

  

 







 






  

 








 














 





 

  

   




reviewbot




   

   







  

 



 

  


   

   

    
 
reviewbot


    
   


  

  

  



    




  1. 
 
    
  
    
   
    This is a review from Review Bot.
    
  Tool: PEP8 Style Checker
    
  Processed Files:
    
    reviewboard/webapi/tests/test_review_request_draft.py
    
  Ignored Files:
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/webapi/tests/test_review_request_draft.py
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Col: 80
    
 E501 line too long (81 > 79 characters)
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 





 

  

   




reviewbot




   

   





  

 



 

  


   

   

    
 
reviewbot


    
   


  

  

  



    




  1. 
 
    
  
    
   
    This is a review from Review Bot.
    
  Tool: Pyflakes
    
  Processed Files:
    
    reviewboard/webapi/tests/test_review_request_draft.py
    
  Ignored Files:
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




david




   

   

  

 



 















 





 

  

   




reviewbot




   

   





  

 



 

  


   

   

    
 
reviewbot


    
   


  

  

  



    




  1. 
 
    
  
    
   
    This is a review from Review Bot.
    
  Tool: PEP8 Style Checker
    
  Processed Files:
    
    setup.py
    
    reviewboard/webapi/tests/base.py
    
    reviewboard/site/tests.py
    
    reviewboard/webapi/tests/test_review_request_draft.py
    
  Ignored Files:
    
    reviewboard/templates/reviews/review_detail.html
    
    reviewboard/templates/reviews/user_page.html
    
    reviewboard/templates/reviews/ui/base.html
    
    reviewboard/templates/reviews/review_reply.html
    
    reviewboard/templates/base.html
    
    reviewboard/templates/accounts/password_reset_confirm.html
    
    reviewboard/templates/404.html
    
    reviewboard/templates/accounts/password_reset_complete.html
    
    reviewboard/templates/diffviewer/diff_file_fragment.html
    
    reviewboard/templates/reviews/review_request_box.html
    
    reviewboard/templates/admin/repository_confirmations.html
    
    reviewboard/templates/reviews/dashboard_entry.html
    
    reviewboard/templates/diffviewer/diff_fragment_error.html
    
    reviewboard/templates/reviews/review_issue_summary_table.html
    
    reviewboard/templates/admin/base_site.html
    
    reviewboard/templates/notifications/review_request_email.html
    
    reviewboard/templates/admin/widgets/w-actions.html
    
    reviewboard/templates/notifications/review_request_email.txt
    
    reviewboard/templates/accounts/login.html
    
    reviewboard/templates/accounts/password_reset_email.txt
    
    reviewboard/templates/base/branding.html
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




reviewbot




   

   







  

 



 

  


   

   

    
 
reviewbot


    
   


  

  

  



    




  1. 
 
    
  
    
   
    This is a review from Review Bot.
    
  Tool: Pyflakes
    
  Processed Files:
    
    setup.py
    
    reviewboard/webapi/tests/base.py
    
    reviewboard/site/tests.py
    
    reviewboard/webapi/tests/test_review_request_draft.py
    
  Ignored Files:
    
    reviewboard/templates/reviews/review_detail.html
    
    reviewboard/templates/reviews/user_page.html
    
    reviewboard/templates/reviews/ui/base.html
    
    reviewboard/templates/reviews/review_reply.html
    
    reviewboard/templates/base.html
    
    reviewboard/templates/accounts/password_reset_confirm.html
    
    reviewboard/templates/404.html
    
    reviewboard/templates/accounts/password_reset_complete.html
    
    reviewboard/templates/diffviewer/diff_file_fragment.html
    
    reviewboard/templates/reviews/review_request_box.html
    
    reviewboard/templates/admin/repository_confirmations.html
    
    reviewboard/templates/reviews/dashboard_entry.html
    
    reviewboard/templates/diffviewer/diff_fragment_error.html
    
    reviewboard/templates/reviews/review_issue_summary_table.html
    
    reviewboard/templates/admin/base_site.html
    
    reviewboard/templates/notifications/review_request_email.html
    
    reviewboard/templates/admin/widgets/w-actions.html
    
    reviewboard/templates/notifications/review_request_email.txt
    
    reviewboard/templates/accounts/login.html
    
    reviewboard/templates/accounts/password_reset_email.txt
    
    reviewboard/templates/base/branding.html
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/site/tests.py
       


        (Diff revision 2)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    'templatetags' imported but unused
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




david




   

   

  

 



 















 





 

  

   




reviewbot




   

   





  

 



 

  


   

   

    
 
reviewbot


    
   


  

  

  



    




  1. 
 
    
  
    
   
    This is a review from Review Bot.
    
  Tool: PEP8 Style Checker
    
  Processed Files:
    
    reviewboard/webapi/tests/test_review_request_draft.py
    
  Ignored Files:
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




reviewbot




   

   





  

 



 

  


   

   

    
 
reviewbot


    
   


  

  

  



    




  1. 
 
    
  
    
   
    This is a review from Review Bot.
    
  Tool: Pyflakes
    
  Processed Files:
    
    reviewboard/webapi/tests/test_review_request_draft.py
    
  Ignored Files:
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Completed

   

  




  

   

    Change Summary:
   

   

    
Pushed to master (60fa742).