Don't blindly call next_page_number() or previous_page_number().
Review Request #4588 — Created Sept. 17, 2013 and submitted
Don't blindly call next_page_number() or previous_page_number().
The pagination methods have been changed to raise EmptyPageError if there's no
such page. We therefore can't blindly add things to the context, but rather
should check that the pages exist before we call these methods.
- Loaded a diff that spanned multiple pages.
- Ran unit tests
Description | From | Last Updated |
---|---|---|
Can you put a blank line separating these too? |
chipx86 |
-
This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/diffviewer/views.py
Ignored Files:
-
This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/diffviewer/views.py
Ignored Files: