Summary

Make sure to always fix up the MEDIA_ROOT after admin tests.

Review Request #4584 — Created Sept. 17, 2013 and submitted Sept. 17, 2013, 4:08 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Make sure to always fix up the MEDIA_ROOT after admin tests.

If UpdateTests.testManualUpdatesRequiredBadUpload fails (say, due to something
being rendering the base.html template), it will leave settings.MEDIA_ROOT and
siteconfig's site_media_root in a broken state. This breaks a bunch of other
tests, which is highly confusing.

Testing Done

Ran into this case when working on my django1.5 branch, and this fixed it.

Expand All
Collapse All

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/admin/tests.py
Ignored Files:

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/admin/tests.py
Ignored Files:

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (1c6a3a1).