Get rid of deprecated TestCase assertion methods.

 






 

 


  Review Request #4581
  —
  Created Sept. 17, 2013 and submitted 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Get rid of deprecated TestCase assertion methods.


TestCase has a bunch of methods which have been replaced with other names for

various reasons. We've fixed up most but not all of these. This change converts

all of these to use the new names.

 








  


 
 

  
Ran unit tests

 







 









 





  








 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
local variable 'svn_repo_path' is assigned to but never used

      		
      
       reviewbotreviewbot
      
      
       
      
     




     

      
       
       
assertNone/assertIsNotNone is not in Python 2.6.

      		
      
       chipx86chipx86
      
      
       
      
     


    
   

  

 







 






  

 








 














 





 

  

   




reviewbot




   

   





  

 



 

  


   

   

    
 
reviewbot


    
   


  

  

  



    




  1. 
 
    
  
    
   
    This is a review from Review Bot.
    
  Tool: PEP8 Style Checker
    
  Processed Files:
    
    reviewboard/webapi/tests/test_watched_review_group.py
    
    reviewboard/webapi/tests/test_file_attachment_draft.py
    
    reviewboard/webapi/tests/test_watched_review_request.py
    
    reviewboard/reviews/tests.py
    
    reviewboard/webapi/tests/test_review_request.py
    
    reviewboard/diffviewer/tests.py
    
    reviewboard/changedescs/tests.py
    
    reviewboard/webapi/tests/test_screenshot.py
    
    reviewboard/webapi/tests/test_file_attachment.py
    
  Ignored Files:
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




reviewbot




   

   







  

 



 

  


   

   

    
 
reviewbot


    
   


  

  

  



    




  1. 
 
    
  
    
   
    This is a review from Review Bot.
    
  Tool: Pyflakes
    
  Processed Files:
    
    reviewboard/webapi/tests/test_watched_review_group.py
    
    reviewboard/webapi/tests/test_file_attachment_draft.py
    
    reviewboard/webapi/tests/test_watched_review_request.py
    
    reviewboard/reviews/tests.py
    
    reviewboard/webapi/tests/test_review_request.py
    
    reviewboard/diffviewer/tests.py
    
    reviewboard/changedescs/tests.py
    
    reviewboard/webapi/tests/test_screenshot.py
    
    reviewboard/webapi/tests/test_file_attachment.py
    
  Ignored Files:
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/reviews/tests.py
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    local variable 'svn_repo_path' is assigned to but never used
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




david




   

   

  

 



 















 





 

  

   




reviewbot




   

   





  

 



 

  


   

   

    
 
reviewbot


    
   


  

  

  



    




  1. 
 
    
  
    
   
    This is a review from Review Bot.
    
  Tool: PEP8 Style Checker
    
  Processed Files:
    
    reviewboard/webapi/tests/test_watched_review_group.py
    
    reviewboard/webapi/tests/test_file_attachment_draft.py
    
    reviewboard/webapi/tests/test_watched_review_request.py
    
    reviewboard/reviews/tests.py
    
    reviewboard/webapi/tests/test_review_request.py
    
    reviewboard/diffviewer/tests.py
    
    reviewboard/changedescs/tests.py
    
    reviewboard/webapi/tests/test_screenshot.py
    
    reviewboard/webapi/tests/test_file_attachment.py
    
  Ignored Files:
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




reviewbot




   

   





  

 



 

  


   

   

    
 
reviewbot


    
   


  

  

  



    




  1. 
 
    
  
    
   
    This is a review from Review Bot.
    
  Tool: Pyflakes
    
  Processed Files:
    
    reviewboard/webapi/tests/test_watched_review_group.py
    
    reviewboard/webapi/tests/test_file_attachment_draft.py
    
    reviewboard/webapi/tests/test_watched_review_request.py
    
    reviewboard/reviews/tests.py
    
    reviewboard/webapi/tests/test_review_request.py
    
    reviewboard/diffviewer/tests.py
    
    reviewboard/changedescs/tests.py
    
    reviewboard/webapi/tests/test_screenshot.py
    
    reviewboard/webapi/tests/test_file_attachment.py
    
  Ignored Files:
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/reviews/tests.py
       


        (Diff revision 2)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    assertNone/assertIsNotNone is not in Python 2.6.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




david




   

   

  

 



 















 





 

  

   




reviewbot




   

   





  

 



 

  


   

   

    
 
reviewbot


    
   


  

  

  



    




  1. 
 
    
  
    
   
    This is a review from Review Bot.
    
  Tool: PEP8 Style Checker
    
  Processed Files:
    
    reviewboard/webapi/tests/test_watched_review_group.py
    
    reviewboard/webapi/tests/test_file_attachment_draft.py
    
    reviewboard/webapi/tests/test_watched_review_request.py
    
    reviewboard/reviews/tests.py
    
    reviewboard/webapi/tests/test_review_request.py
    
    reviewboard/diffviewer/tests.py
    
    reviewboard/changedescs/tests.py
    
    reviewboard/webapi/tests/test_screenshot.py
    
    reviewboard/webapi/tests/test_file_attachment.py
    
  Ignored Files:
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




reviewbot




   

   





  

 



 

  


   

   

    
 
reviewbot


    
   


  

  

  



    




  1. 
 
    
  
    
   
    This is a review from Review Bot.
    
  Tool: Pyflakes
    
  Processed Files:
    
    reviewboard/webapi/tests/test_watched_review_group.py
    
    reviewboard/webapi/tests/test_file_attachment_draft.py
    
    reviewboard/webapi/tests/test_watched_review_request.py
    
    reviewboard/reviews/tests.py
    
    reviewboard/webapi/tests/test_review_request.py
    
    reviewboard/diffviewer/tests.py
    
    reviewboard/changedescs/tests.py
    
    reviewboard/webapi/tests/test_screenshot.py
    
    reviewboard/webapi/tests/test_file_attachment.py
    
  Ignored Files:
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Completed

   

  




  

   

    Change Summary:
   

   

    
Pushed to master (8fb0f68).