This change has been marked as completed.

Describe the completed change (optional):

Pushed to master (700c3e8).

Summary

Change django.conf.urls.defaults -> django.conf.urls (djblets)

Review Request #4570 — Created Sept. 15, 2013 and submitted 11 years, 7 months ago

Information

Owner

david*

Repository

Djblets

Branch

master

Bugs

Depends On

Reviewers

Groups

djblets

People

Description*

Change django.conf.urls.defaults -> django.conf.urls (djblets)
Django 1.4 changed the namespace for 'patterns' and 'url' from

django.conf.urls.defaults to django.conf.urls. This was listed in the

deprecation notes, but we never updated it because 1.4 maintained

compatibility. 1.5 got rid of the compatibility shim, so we need to actually

update now.

Testing Done


Ran unit tests
Used in conjunction with review board

Issues

Description	From	Last Updated
'handler500' imported but unused	reviewbot	11 years, 7 months ago
'handler404' imported but unused	reviewbot	11 years, 7 months ago
'handler500' imported but unused	reviewbot	11 years, 7 months ago
These are needed. Django will try to import the handler404 and handler500 from this (since it's the root URL processor) …	chipx86	11 years, 7 months ago
There are no open issues

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
djblets/extensions/urls.py
djblets/util/misc.py
djblets/webapi/resources.py
djblets/testing/urls.py
djblets/util/rooturl.py
djblets/extensions/tests.py
djblets/extensions/test/urls.py
djblets/extensions/base.py
djblets/extensions/resources.py
djblets/feedview/test_urls.py
djblets/log/urls.py
Ignored Files:

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
djblets/extensions/urls.py
djblets/util/misc.py
djblets/webapi/resources.py
djblets/testing/urls.py
djblets/util/rooturl.py
djblets/extensions/tests.py
djblets/extensions/test/urls.py
djblets/extensions/base.py
djblets/extensions/resources.py
djblets/feedview/test_urls.py
djblets/log/urls.py
Ignored Files:

djblets/feedview/test_urls.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'handler500' imported but unused
```
djblets/util/rooturl.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'handler404' imported but unused
```
djblets/util/rooturl.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'handler500' imported but unused
```

Diff:

Revision 2 (+11 -11)

Show changes

	djblets/extensions/base.py
	djblets/extensions/resources.py
	djblets/extensions/tests.py
	djblets/extensions/urls.py
	djblets/extensions/test/urls.py
	djblets/feedview/test_urls.py
	djblets/log/urls.py
	djblets/testing/urls.py
	3 more

djblets/util/rooturl.py (Diff revision 2)

The issue has been resolved. Show all issues

These are needed. Django will try to import the handler404 and handler500 from this (since it's the root URL processor) on 404s and 500s.

david 11 years, 7 months ago

I'm not sure I follow. In the Django source, it only imports these from django.conf.urls, and everything seems to work fine without these.

chipx86 11 years, 7 months ago

It might be fine, but I'm not yet convinced. The docs claim it pulls them initially from the root URL resolver, which is this file. This was once broken, and I fixed it by adding these imports as per the docs (way back when). I want to be 100% sure things work correctly in both debug and non-debug setups before making this change.

Diff:

Revision 3 (+11 -11)

Show changes

	djblets/extensions/base.py
	djblets/extensions/resources.py
	djblets/extensions/tests.py
	djblets/extensions/urls.py
	djblets/extensions/test/urls.py
	djblets/feedview/test_urls.py
	djblets/log/urls.py
	djblets/testing/urls.py
	3 more

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (700c3e8).