Summary

Fix unit test failures when the host has no internet connection.

Review Request #4569 — Created Sept. 15, 2013 and submitted Sept. 17, 2013, 12:52 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Fix unit test failures when the host has no internet connection.

One annoying aspect of working on planes is that several of the unit tests fail
in ugly ways if the host has no internet access. I've added a check that tries
to resolve the hostname for google.com and skips any tests that require network
access.

Eventually, we should fix these tests to use mocks running on the host to
completely isolate us from third-party servers and internet connections.

Testing Done

Ran unit tests whilst in-flight.

Issues

Description	From	Last Updated
'P4Error' imported but unused	reviewbot	Sept. 15, 2013, 9:35 a.m.
'P4Error' imported but unused	reviewbot	Sept. 15, 2013, 9:36 a.m.
'find_module' imported but unused	reviewbot	Sept. 15, 2013, 9:48 a.m.
Instead of this going into every test, how about an @online_only decorator or something that does this?	chipx86	Sept. 15, 2013, 9:03 p.m.

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/scmtools/tests.py
reviewboard/testing/init.py
reviewboard/ssh/errors.py
Ignored Files:

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/scmtools/tests.py
reviewboard/testing/init.py
reviewboard/ssh/errors.py
Ignored Files:

reviewboard/scmtools/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'P4Error' imported but unused
```

Diff:

Revision 2 (+54 -31)

Show changes

	reviewboard/scmtools/tests.py
	reviewboard/ssh/errors.py
	reviewboard/testing/__init__.py

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/scmtools/tests.py
reviewboard/testing/init.py
reviewboard/ssh/errors.py
Ignored Files:

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/scmtools/tests.py
reviewboard/testing/init.py
reviewboard/ssh/errors.py
Ignored Files:

reviewboard/scmtools/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
'P4Error' imported but unused
```

Diff:

Revision 3 (+54 -40)

Show changes

	reviewboard/scmtools/tests.py
	reviewboard/ssh/errors.py
	reviewboard/testing/__init__.py

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/scmtools/tests.py
reviewboard/testing/init.py
reviewboard/ssh/errors.py
Ignored Files:

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/scmtools/tests.py
reviewboard/testing/init.py
reviewboard/ssh/errors.py
Ignored Files:

reviewboard/scmtools/tests.py (Diff revision 3)
The issue has been resolved. Show all issues
```
'find_module' imported but unused
```

Diff:

Revision 4 (+54 -41)

Show changes

	reviewboard/scmtools/tests.py
	reviewboard/ssh/errors.py
	reviewboard/testing/__init__.py

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/scmtools/tests.py
reviewboard/testing/init.py
reviewboard/ssh/errors.py
Ignored Files:

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/scmtools/tests.py
reviewboard/testing/init.py
reviewboard/ssh/errors.py
Ignored Files:

reviewboard/scmtools/tests.py (Diff revision 4)

The issue has been resolved. Show all issues

Instead of this going into every test, how about an @online_only decorator or something that does this?

Diff:

Revision 5 (+60 -43)

Show changes

	reviewboard/scmtools/tests.py
	reviewboard/ssh/errors.py
	reviewboard/testing/__init__.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (9416b03)