• 
      

    Move away from most fixtures on all non-webapi apps.

    Review Request #4553 — Created Sept. 10, 2013 and submitted

    Information

    Review Board
    master

    Reviewers

    Move away from most fixtures on all non-webapi apps.

    This removes the usage of the test_reviewrequests and most of the
    test_scmtools fixtures from the non-webapi unit tests. Instead, these
    test suites now use the new TestCase class's utility methods for
    creating test objects.

    With the test suite as it originally was, on my machine, it took roughly
    159 seconds to complete. With this change, it's down to ~143. After my
    upcoming change, which also removes data from the test_scmtools fixture,
    the time drops to ~88.

    Unit tests pass.

    reviewbot
    1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      reviewboard/attachments/tests.py
      reviewboard/accounts/tests.py
      reviewboard/reviews/tests.py
      reviewboard/notifications/tests.py
      reviewboard/diffviewer/tests.py
      Ignored Files:
      reviewboard/accounts/fixtures/test_users.json

    2. 
        
    reviewbot
    1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
      reviewboard/attachments/tests.py
      reviewboard/accounts/tests.py
      reviewboard/reviews/tests.py
      reviewboard/notifications/tests.py
      reviewboard/diffviewer/tests.py
      Ignored Files:
      reviewboard/accounts/fixtures/test_users.json

    2. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed