Summary

Load diff files from javascript.

Review Request #4546 — Created Sept. 9, 2013 and submitted Sept. 11, 2013, 11:24 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Load diff files from javascript.

This changes the diff viewer to create the diff-container items from javascript
instead of the django template.

Testing Done


Loaded a few different diff revisions and interdiffs and saw that things

  loaded correctly.
Ran js-tests.
Ran jshint.

Expand All
Collapse All

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
Ignored Files:
reviewboard/templates/diffviewer/view_diff.html
reviewboard/static/rb/js/pages/views/diffViewerPageView.js

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
Ignored Files:
reviewboard/templates/diffviewer/view_diff.html
reviewboard/static/rb/js/pages/views/diffViewerPageView.js

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (5462936).