Summary

Split resources.py into per-resource files.

Review Request #4524 — Created Sept. 3, 2013 and submitted Sept. 3, 2013, 6:36 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Split resources.py into per-resource files.
resources.py has become unmanageable, so it's now split up into a bunch

of different files.
The problem going into this was the interdependency between resources.

At class definition time, they neatly form a tree, but at request

handler time, there are circular dependencies.
The solution to this is to have a Resources class that dynamically loads

the right resources from the right places upon request, and caches

them. All references to resource instances go through this, and it

handles dishing them out. It also handles registering them against

models.
The logic for resources haven't changed. It's just code movement. The

only major change here is the logic in resources/init.py.

Testing Done

Unit tests run.

Docs build.

Web UI works.

Issues

Description	From	Last Updated
undefined name 'logging'	reviewbot	Sept. 3, 2013, 5:12 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Sept. 3, 2013, 4:42 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Sept. 3, 2013, 4:42 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Sept. 3, 2013, 4:42 p.m.
Col: 21 E126 continuation line over-indented for hanging indent	reviewbot	Sept. 3, 2013, 4:43 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Sept. 3, 2013, 4:43 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Sept. 3, 2013, 4:44 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Sept. 3, 2013, 4:44 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Sept. 3, 2013, 4:44 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Sept. 3, 2013, 4:44 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Sept. 3, 2013, 4:44 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Sept. 3, 2013, 4:44 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Sept. 3, 2013, 4:44 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Sept. 3, 2013, 4:45 p.m.
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	Sept. 3, 2013, 4:45 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Sept. 3, 2013, 5:07 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Sept. 3, 2013, 5:08 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Sept. 3, 2013, 5:09 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Sept. 3, 2013, 5:09 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Sept. 3, 2013, 5:09 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Sept. 3, 2013, 5:10 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Sept. 3, 2013, 5:10 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Sept. 3, 2013, 5:11 p.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	Sept. 3, 2013, 5:11 p.m.
Col: 22 E201 whitespace after '('	reviewbot	Sept. 3, 2013, 5:11 p.m.
Col: 22 E128 continuation line under-indented for visual indent	reviewbot	Sept. 3, 2013, 5:11 p.m.
Col: 25 E201 whitespace after '('	reviewbot	Sept. 3, 2013, 5:11 p.m.
Col: 25 E128 continuation line under-indented for visual indent	reviewbot	Sept. 3, 2013, 5:12 p.m.
Col: 25 E128 continuation line under-indented for visual indent	reviewbot	Sept. 3, 2013, 5:12 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Sept. 3, 2013, 5:12 p.m.
What's with all the commented-out imports here?	david	Sept. 3, 2013, 6:04 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Sept. 3, 2013, 5:44 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Sept. 3, 2013, 5:44 p.m.
Col: 22 E201 whitespace after '('	reviewbot	Sept. 3, 2013, 5:39 p.m.
Col: 25 E201 whitespace after '('	reviewbot	Sept. 3, 2013, 5:39 p.m.
Col: 22 E128 continuation line under-indented for visual indent	reviewbot	Sept. 3, 2013, 5:39 p.m.
Col: 25 E128 continuation line under-indented for visual indent	reviewbot	Sept. 3, 2013, 5:39 p.m.
Col: 25 E128 continuation line under-indented for visual indent	reviewbot	Sept. 3, 2013, 5:39 p.m.

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/webapi/resources/repository.py
reviewboard/webapi/resources/repository_commits.py
reviewboard/webapi/resources/repository_info.py
reviewboard/webapi/resources/review_group.py
reviewboard/webapi/resources/repository_branches.py
reviewboard/webapi/resources/draft_file_attachment.py
reviewboard/webapi/resources/file_attachment.py
reviewboard/webapi/resources/validate_diff.py
reviewboard/webapi/resources/base_watched_object.py
reviewboard/webapi/resources/draft_screenshot.py
reviewboard/webapi/resources/diff.py
reviewboard/webapi/resources/hosting_service_account.py
reviewboard/webapi/resources/review_diff_comment.py
reviewboard/webapi/resources/review_reply.py
reviewboard/webapi/resources/base_diff_comment.py
reviewboard/webapi/resources/root.py
reviewboard/webapi/resources/base_file_attachment.py
reviewboard/webapi/resources/review_reply_file_attachment_comment.py
reviewboard/webapi/resources/review_file_attachment_comment.py
reviewboard/webapi/resources/change.py
reviewboard/webapi/resources/session.py
reviewboard/webapi/resources/review_request_last_update.py
reviewboard/webapi/tests/urls.py
reviewboard/webapi/resources/review_request_draft.py
reviewboard/webapi/resources/review_reply_screenshot_comment.py
reviewboard/webapi/resources/review_screenshot_comment.py
reviewboard/webapi/resources/base_comment.py
reviewboard/webapi/resources/patched_file.py
reviewboard/webapi/resources/base_screenshot_comment.py
reviewboard/webapi/resources/screenshot.py
reviewboard/webapi/resources/watched.py
reviewboard/webapi/resources/base_file_attachment_comment.py
reviewboard/webapi/resources/review_request.py
reviewboard/webapi/resources/default_reviewer.py
reviewboard/webapi/resources/validation.py
reviewboard/webapi/resources/original_file.py
reviewboard/webapi/resources/base_review.py
reviewboard/webapi/resources/server_info.py
reviewboard/urls.py
reviewboard/webapi/resources/review_reply_draft.py
reviewboard/webapi/resources/filediff_comment.py
reviewboard/webapi/resources/watched_review_group.py
reviewboard/webapi/resources/init.py
reviewboard/webapi/resources/base_screenshot.py
reviewboard/webapi/resources/watched_review_request.py
reviewboard/webapi/resources/screenshot_comment.py
reviewboard/webapi/resources/file_attachment_comment.py
reviewboard/webapi/resources/search.py
reviewboard/webapi/resources/filediff.py
reviewboard/webapi/resources/review_group_user.py
reviewboard/webapi/resources/review.py
reviewboard/webapi/resources/user.py
docs/manual/_ext/webapidocs.py
reviewboard/webapi/resources/review_draft.py
reviewboard/webapi/resources/review_reply_diff_comment.py
Ignored Files:
reviewboard/webapi/resources.py
docs/manual/webapi/2.0/resources/review-list.txt
docs/manual/webapi/2.0/resources/review-reply-screenshot-comment.txt
docs/manual/webapi/2.0/resources/review-request.txt
docs/manual/webapi/2.0/resources/review-diff-comment.txt
docs/manual/webapi/2.0/resources/review-request-draft.txt
docs/manual/webapi/2.0/resources/screenshot-list.txt
docs/manual/webapi/2.0/resources/review-reply.txt
docs/manual/webapi/2.0/resources/patched-file.txt
docs/manual/webapi/2.0/resources/review-group.txt
docs/manual/webapi/2.0/resources/repository-list.txt
docs/manual/webapi/2.0/resources/file-attachment.txt
docs/manual/webapi/2.0/resources/hosting-service-account.txt
docs/manual/webapi/2.0/resources/diff-list.txt
docs/manual/webapi/2.0/resources/validate-diff.txt
docs/manual/webapi/2.0/resources/review-reply-file-attachment-comment-list.txt
docs/manual/webapi/2.0/resources/server-info.txt
docs/manual/webapi/2.0/resources/extension.txt
docs/manual/webapi/2.0/resources/draft-file-attachment.txt
docs/manual/webapi/2.0/resources/review-reply-screenshot-comment-list.txt
docs/manual/webapi/2.0/resources/draft-screenshot-list.txt
docs/manual/webapi/2.0/resources/review-request-list.txt
docs/manual/webapi/2.0/resources/default-reviewer-list.txt
docs/manual/webapi/2.0/resources/review-screenshot-comment.txt
docs/manual/webapi/2.0/resources/watched-review-request.txt
docs/manual/webapi/2.0/resources/hosting-service-account-list.txt
docs/manual/webapi/2.0/resources/watched.txt
docs/manual/webapi/2.0/resources/change.txt
docs/manual/webapi/2.0/resources/watched-review-group.txt
docs/manual/webapi/2.0/resources/review-screenshot-comment-list.txt
docs/manual/webapi/2.0/resources/review-group-list.txt
docs/manual/webapi/2.0/resources/repository.txt
docs/manual/webapi/2.0/resources/file-attachment-list.txt
docs/manual/webapi/2.0/resources/search.txt
docs/manual/webapi/2.0/resources/watched-review-request-list.txt
docs/manual/webapi/2.0/resources/extension-list.txt
docs/manual/webapi/2.0/resources/user-list.txt
docs/manual/webapi/2.0/resources/default-reviewer.txt
docs/manual/webapi/2.0/resources/file-attachment-comment-list.txt
docs/manual/webapi/2.0/resources/repository-info.txt
docs/manual/webapi/2.0/resources/review-reply-list.txt
docs/manual/webapi/2.0/resources/draft-screenshot.txt
docs/manual/webapi/2.0/resources/review-group-user.txt
docs/manual/webapi/2.0/resources/review-group-user-list.txt
docs/manual/webapi/2.0/resources/file-diff.txt
docs/manual/webapi/2.0/resources/file-diff-comment-list.txt
docs/manual/webapi/2.0/resources/watched-review-group-list.txt
docs/manual/webapi/2.0/resources/root.txt
docs/manual/webapi/2.0/resources/original-file.txt
docs/manual/webapi/2.0/resources/review-reply-file-attachment-comment.txt
docs/manual/webapi/2.0/resources/draft-file-attachment-list.txt
docs/manual/webapi/2.0/resources/review.txt
docs/manual/webapi/2.0/resources/review-reply-draft.txt
docs/manual/webapi/2.0/resources/review-draft.txt
docs/manual/webapi/2.0/resources/review-file-attachment-comment-list.txt
docs/manual/webapi/2.0/resources/review-reply-diff-comment-list.txt
docs/manual/webapi/2.0/resources/screenshot.txt
docs/manual/webapi/2.0/resources/review-request-last-update.txt
docs/manual/webapi/2.0/resources/review-diff-comment-list.txt
docs/manual/webapi/2.0/resources/diff.txt
docs/manual/webapi/2.0/resources/file-attachment-comment.txt
docs/manual/webapi/2.0/resources/screenshot-comment-list.txt
docs/manual/webapi/2.0/resources/file-diff-list.txt
docs/manual/webapi/2.0/resources/session.txt
docs/manual/webapi/2.0/resources/review-file-attachment-comment.txt
docs/manual/webapi/2.0/resources/change-list.txt
docs/manual/webapi/2.0/resources/validation.txt
docs/manual/webapi/2.0/resources/user.txt
docs/manual/webapi/2.0/resources/repository-commits.txt
docs/manual/webapi/2.0/resources/review-reply-diff-comment.txt
docs/manual/webapi/2.0/resources/repository-branches.txt
docs/manual/docs.db

reviewboard/webapi/resources/base_file_attachment.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (81 > 79 characters)
```
reviewboard/webapi/resources/base_watched_object.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/base_watched_object.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/default_reviewer.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 21

 E126 continuation line over-indented for hanging indent
```
reviewboard/webapi/resources/hosting_service_account.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/repository.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (81 > 79 characters)
```
reviewboard/webapi/resources/repository_branches.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/repository_branches.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/repository_branches.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/repository_branches.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/repository_commits.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/repository_commits.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/review_reply_diff_comment.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/review_reply_file_attachment_comment.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (82 > 79 characters)
```
reviewboard/webapi/resources/review_reply_file_attachment_comment.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/review_reply_screenshot_comment.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/review_request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/review_request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/review_request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/review_request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/review_request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/review_request_draft.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (81 > 79 characters)
```
reviewboard/webapi/resources/search.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (83 > 79 characters)
```
reviewboard/webapi/resources/validate_diff.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 22

 E201 whitespace after '('
```
reviewboard/webapi/resources/validate_diff.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 22

 E128 continuation line under-indented for visual indent
```
reviewboard/webapi/resources/validate_diff.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 25

 E201 whitespace after '('
```
reviewboard/webapi/resources/validate_diff.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 25

 E128 continuation line under-indented for visual indent
```
reviewboard/webapi/resources/validate_diff.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 25

 E128 continuation line under-indented for visual indent
```
reviewboard/webapi/resources/validate_diff.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (80 > 79 characters)
```

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/webapi/resources/repository.py
reviewboard/webapi/resources/repository_commits.py
reviewboard/webapi/resources/repository_info.py
reviewboard/webapi/resources/review_group.py
reviewboard/webapi/resources/repository_branches.py
reviewboard/webapi/resources/draft_file_attachment.py
reviewboard/webapi/resources/file_attachment.py
reviewboard/webapi/resources/validate_diff.py
reviewboard/webapi/resources/base_watched_object.py
reviewboard/webapi/resources/draft_screenshot.py
reviewboard/webapi/resources/diff.py
reviewboard/webapi/resources/hosting_service_account.py
reviewboard/webapi/resources/review_diff_comment.py
reviewboard/webapi/resources/review_reply.py
reviewboard/webapi/resources/base_diff_comment.py
reviewboard/webapi/resources/root.py
reviewboard/webapi/resources/base_file_attachment.py
reviewboard/webapi/resources/review_reply_file_attachment_comment.py
reviewboard/webapi/resources/review_file_attachment_comment.py
reviewboard/webapi/resources/change.py
reviewboard/webapi/resources/session.py
reviewboard/webapi/resources/review_request_last_update.py
reviewboard/webapi/tests/urls.py
reviewboard/webapi/resources/review_request_draft.py
reviewboard/webapi/resources/review_reply_screenshot_comment.py
reviewboard/webapi/resources/review_screenshot_comment.py
reviewboard/webapi/resources/base_comment.py
reviewboard/webapi/resources/patched_file.py
reviewboard/webapi/resources/base_screenshot_comment.py
reviewboard/webapi/resources/screenshot.py
reviewboard/webapi/resources/watched.py
reviewboard/webapi/resources/base_file_attachment_comment.py
reviewboard/webapi/resources/review_request.py
reviewboard/webapi/resources/default_reviewer.py
reviewboard/webapi/resources/validation.py
reviewboard/webapi/resources/original_file.py
reviewboard/webapi/resources/base_review.py
reviewboard/webapi/resources/server_info.py
reviewboard/urls.py
reviewboard/webapi/resources/review_reply_draft.py
reviewboard/webapi/resources/filediff_comment.py
reviewboard/webapi/resources/watched_review_group.py
reviewboard/webapi/resources/init.py
reviewboard/webapi/resources/base_screenshot.py
reviewboard/webapi/resources/watched_review_request.py
reviewboard/webapi/resources/screenshot_comment.py
reviewboard/webapi/resources/file_attachment_comment.py
reviewboard/webapi/resources/search.py
reviewboard/webapi/resources/filediff.py
reviewboard/webapi/resources/review_group_user.py
reviewboard/webapi/resources/review.py
reviewboard/webapi/resources/user.py
docs/manual/_ext/webapidocs.py
reviewboard/webapi/resources/review_draft.py
reviewboard/webapi/resources/review_reply_diff_comment.py
Ignored Files:
reviewboard/webapi/resources.py
docs/manual/webapi/2.0/resources/review-list.txt
docs/manual/webapi/2.0/resources/review-reply-screenshot-comment.txt
docs/manual/webapi/2.0/resources/review-request.txt
docs/manual/webapi/2.0/resources/review-diff-comment.txt
docs/manual/webapi/2.0/resources/review-request-draft.txt
docs/manual/webapi/2.0/resources/screenshot-list.txt
docs/manual/webapi/2.0/resources/review-reply.txt
docs/manual/webapi/2.0/resources/patched-file.txt
docs/manual/webapi/2.0/resources/review-group.txt
docs/manual/webapi/2.0/resources/repository-list.txt
docs/manual/webapi/2.0/resources/file-attachment.txt
docs/manual/webapi/2.0/resources/hosting-service-account.txt
docs/manual/webapi/2.0/resources/diff-list.txt
docs/manual/webapi/2.0/resources/validate-diff.txt
docs/manual/webapi/2.0/resources/review-reply-file-attachment-comment-list.txt
docs/manual/webapi/2.0/resources/server-info.txt
docs/manual/webapi/2.0/resources/extension.txt
docs/manual/webapi/2.0/resources/draft-file-attachment.txt
docs/manual/webapi/2.0/resources/review-reply-screenshot-comment-list.txt
docs/manual/webapi/2.0/resources/draft-screenshot-list.txt
docs/manual/webapi/2.0/resources/review-request-list.txt
docs/manual/webapi/2.0/resources/default-reviewer-list.txt
docs/manual/webapi/2.0/resources/review-screenshot-comment.txt
docs/manual/webapi/2.0/resources/watched-review-request.txt
docs/manual/webapi/2.0/resources/hosting-service-account-list.txt
docs/manual/webapi/2.0/resources/watched.txt
docs/manual/webapi/2.0/resources/change.txt
docs/manual/webapi/2.0/resources/watched-review-group.txt
docs/manual/webapi/2.0/resources/review-screenshot-comment-list.txt
docs/manual/webapi/2.0/resources/review-group-list.txt
docs/manual/webapi/2.0/resources/repository.txt
docs/manual/webapi/2.0/resources/file-attachment-list.txt
docs/manual/webapi/2.0/resources/search.txt
docs/manual/webapi/2.0/resources/watched-review-request-list.txt
docs/manual/webapi/2.0/resources/extension-list.txt
docs/manual/webapi/2.0/resources/user-list.txt
docs/manual/webapi/2.0/resources/default-reviewer.txt
docs/manual/webapi/2.0/resources/file-attachment-comment-list.txt
docs/manual/webapi/2.0/resources/repository-info.txt
docs/manual/webapi/2.0/resources/review-reply-list.txt
docs/manual/webapi/2.0/resources/draft-screenshot.txt
docs/manual/webapi/2.0/resources/review-group-user.txt
docs/manual/webapi/2.0/resources/review-group-user-list.txt
docs/manual/webapi/2.0/resources/file-diff.txt
docs/manual/webapi/2.0/resources/file-diff-comment-list.txt
docs/manual/webapi/2.0/resources/watched-review-group-list.txt
docs/manual/webapi/2.0/resources/root.txt
docs/manual/webapi/2.0/resources/original-file.txt
docs/manual/webapi/2.0/resources/review-reply-file-attachment-comment.txt
docs/manual/webapi/2.0/resources/draft-file-attachment-list.txt
docs/manual/webapi/2.0/resources/review.txt
docs/manual/webapi/2.0/resources/review-reply-draft.txt
docs/manual/webapi/2.0/resources/review-draft.txt
docs/manual/webapi/2.0/resources/review-file-attachment-comment-list.txt
docs/manual/webapi/2.0/resources/review-reply-diff-comment-list.txt
docs/manual/webapi/2.0/resources/screenshot.txt
docs/manual/webapi/2.0/resources/review-request-last-update.txt
docs/manual/webapi/2.0/resources/review-diff-comment-list.txt
docs/manual/webapi/2.0/resources/diff.txt
docs/manual/webapi/2.0/resources/file-attachment-comment.txt
docs/manual/webapi/2.0/resources/screenshot-comment-list.txt
docs/manual/webapi/2.0/resources/file-diff-list.txt
docs/manual/webapi/2.0/resources/session.txt
docs/manual/webapi/2.0/resources/review-file-attachment-comment.txt
docs/manual/webapi/2.0/resources/change-list.txt
docs/manual/webapi/2.0/resources/validation.txt
docs/manual/webapi/2.0/resources/user.txt
docs/manual/webapi/2.0/resources/repository-commits.txt
docs/manual/webapi/2.0/resources/review-reply-diff-comment.txt
docs/manual/webapi/2.0/resources/repository-branches.txt
docs/manual/docs.db

reviewboard/webapi/resources/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
undefined name 'logging'
```

Change Summary:

Made most of the changes requested by Review Bot, except some formatting things we did intentionally. You're not the boss of me, Review Bot.

Diff:

Revision 2 (+8614 -7924)

Show changes

	docs/manual/docs.db
	docs/manual/_ext/webapidocs.py
	docs/manual/webapi/2.0/resources/change.txt
	docs/manual/webapi/2.0/resources/change-list.txt
	docs/manual/webapi/2.0/resources/default-reviewer.txt
	docs/manual/webapi/2.0/resources/default-reviewer-list.txt
	docs/manual/webapi/2.0/resources/diff.txt
	docs/manual/webapi/2.0/resources/diff-list.txt
	119 more

Description:: Split resources.py into per-resource files.

resources.py has become unmanageable, so it's now split up into a bunch
of different files.

The problem going into this was the interdependency between resources.
At class definition time, they neatly form a tree, but at request
handler time, there are circular dependencies.

The solution to this is to have a Resources class that dynamically loads
the right resources from the right places upon request, and caches
them. All references to resource instances go through this, and it
handles dishing them out. It also handles registering them against
models.

The logic for resources haven't changed. It's just code movement. The
only major change here is the logic in resources/init.py.
-
-
Reference all resource instances in a Resources object instance.
-
-
This collects all the resource instances into a container object
- called Resources. This is something that can be empty at first and
- easily importable, and later filled in, helping with the upcoming
- resources file split work. Resource code that executes after
- initialization and needs to reference other resources can import this
- object and reference the instances within.
-
-
Basically, this breaks the circular dependency problem.

reviewboard/webapi/resources/repository_branches.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/repository_branches.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/validate_diff.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 22

 E201 whitespace after '('
```
reviewboard/webapi/resources/validate_diff.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 25

 E201 whitespace after '('
```
reviewboard/webapi/resources/validate_diff.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 22

 E128 continuation line under-indented for visual indent
```
reviewboard/webapi/resources/validate_diff.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 25

 E128 continuation line under-indented for visual indent
```
reviewboard/webapi/resources/validate_diff.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 25

 E128 continuation line under-indented for visual indent
```

reviewboard/webapi/resources/base_diff_comment.py (Diff revision 2)

The issue has been resolved. Show all issues

What's with all the commented-out imports here?

chipx86 Sept. 3, 2013, 6:05 p.m.

Oops, must have forgotten that file.

My process for splitting was to first split out the classes into each file, then copy a commented out version of all of resource.py's imports into each, then run pyflakes, uncomment what I needed, and delete the rest. Had some nice little vim macros set up for it. I apparently didn't run the "delete the commented lines" one here.

david Sept. 3, 2013, 6:06 p.m.

You sure it didn't delete any real comments in the other files?

chipx86 Sept. 3, 2013, 6:11 p.m.

It only deleted lines matching '^#". The cursor always ended up on the very last import, never anywhere inside the classes.

david Sept. 3, 2013, 6:23 p.m.
```
OK. Once you fix this file, ship it.
```

Status:: Completed

		Split resources.py into per-resource files.

		resources.py has become unmanageable, so it's now split up into a bunch
		of different files.

		The problem going into this was the interdependency between resources.
		At class definition time, they neatly form a tree, but at request
		handler time, there are circular dependencies.

		The solution to this is to have a Resources class that dynamically loads
		the right resources from the right places upon request, and caches
		them. All references to resource instances go through this, and it
		handles dishing them out. It also handles registering them against
		models.

		The logic for resources haven't changed. It's just code movement. The
		only major change here is the logic in resources/init.py.
-
-		Reference all resource instances in a Resources object instance.
-
-		This collects all the resource instances into a container object
-		called Resources. This is something that can be empty at first and
-		easily importable, and later filled in, helping with the upcoming
-		resources file split work. Resource code that executes after
-		initialization and needs to reference other resources can import this
-		object and reference the instances within.
-
-		Basically, this breaks the circular dependency problem.