Summary

Move BaseWebAPITestCase and ValidateDiffResourceTests into new files.

Review Request #4513 — Created Aug. 29, 2013 and submitted Aug. 30, 2013, 3:10 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Move BaseWebAPITestCase and ValidateDiffResourceTests into new files.

BaseWebAPITestCase has been moved into webapi/tests/base.py, and
ValidateDiffResourceTests have been moved into
webapi/tests/validate_diff.py.

Testing Done

Unit tests pass.

Issues

Description	From	Last Updated
This shouldn't be necessary--nose should find it.	david	Aug. 30, 2013, 1:58 p.m.
'ValidateDiffResourceTests' imported but unused	reviewbot	Aug. 29, 2013, 7:58 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Aug. 30, 2013, 2:15 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Aug. 30, 2013, 2:15 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Aug. 30, 2013, 2:15 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	Aug. 30, 2013, 2:15 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Aug. 30, 2013, 2:14 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Aug. 30, 2013, 2:15 p.m.

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/webapi/tests/validate_diff.py
reviewboard/webapi/tests/base.py
reviewboard/webapi/tests/init.py
Ignored Files:

reviewboard/webapi/tests/base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/tests/base.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 17

 E126 continuation line over-indented for hanging indent
```
reviewboard/webapi/tests/base.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80

 E501 line too long (81 > 79 characters)
```
reviewboard/webapi/tests/base.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 17

 E126 continuation line over-indented for hanging indent
```
reviewboard/webapi/tests/validate_diff.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80

 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/tests/validate_diff.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (81 > 79 characters)
```

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/webapi/tests/validate_diff.py
reviewboard/webapi/tests/base.py
reviewboard/webapi/tests/init.py
Ignored Files:

reviewboard/webapi/tests/__init__.py (Diff revision 1)
The issue has been dropped. Show all issues
```
'ValidateDiffResourceTests' imported but unused
```

reviewboard/webapi/tests/__init__.py (Diff revision 1)

The issue has been dropped. Show all issues

This shouldn't be necessary--nose should find it.

chipx86 Aug. 30, 2013, 1:58 p.m.

It doesn't. I have to include that.

It's probably because these tests are in init.py, I'd guess. I'll look into all this again when that file is fully split up and becomes blank, but for now, these need to stay in.

Status:: Completed