• 
      

    Call success and update draft field when setting the close description.

    Review Request #4504 — Created Aug. 28, 2013 and submitted

    Information

    Review Board
    master

    Reviewers

    Call success and update draft field when setting the close description.
    
    The changeDescription field works kind of strangely when a review request is
    closed. Rather than setting a field in a draft and asking it to save, it calls
    close() with the new text. Unfortunately, the changeDescription field in
    reviewRequest.draft was getting out of sync (since it wasn't updated), and the
    success callback was never triggered. This fixes both those issues.
    Used in conjunction with my markdown change.
    Description From Last Updated

    These are two separate things. Mind putting a blank line between them?

    chipx86chipx86
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
        Ignored Files:
          reviewboard/static/rb/js/models/reviewRequestEditorModel.js
      
      
    2. 
        
    reviewbot
    1. This is a review from Review Bot.
        Tool: Pyflakes
        Processed Files:
        Ignored Files:
          reviewboard/static/rb/js/models/reviewRequestEditorModel.js
      
      
    2. 
        
    chipx86
    1. 
        
    2. Show all issues
      These are two separate things. Mind putting a blank line between them?
    3. 
        
    david
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
        Ignored Files:
          reviewboard/static/rb/js/models/reviewRequestEditorModel.js
      
      
    2. 
        
    reviewbot
    1. This is a review from Review Bot.
        Tool: Pyflakes
        Processed Files:
        Ignored Files:
          reviewboard/static/rb/js/models/reviewRequestEditorModel.js
      
      
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (155e613).