Summary

For edit icons on inline editors, use CSS visibility instead of display.

Review Request #4503 — Created Aug. 28, 2013 and submitted Aug. 28, 2013, 5:46 p.m.

Information

Owner

david

Repository

Djblets

Branch

master

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

For edit icons on inline editors, use CSS visibility instead of display.

We try to use CSS min-height on the labels for inline editors to keep them the
same height when the edit icon disappears, which works for the most part,
except many browsers think that the text baseline moves, which still makes the
text jump by a pixel or two.

This change alters our javascript to manipulate the visibility parameter of the
icon rather than just calling .show() and .hide(), which retains space for the
element on the page.

Testing Done

Opened and closed a bunch of inline editors and saw it be silky smooth.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    djblets/media/js/jquery.gravy.js

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
  Ignored Files:
    djblets/media/js/jquery.gravy.js

djblets/media/js/jquery.gravy.js (Diff revision 1)

Is this the default fadeOut? Or does this change the animation style? I think it uses 'linear' by default.

david Aug. 28, 2013, 5:24 p.m.

This is the default for just about all of jquery's animations.

chipx86 Aug. 28, 2013, 5:38 p.m.
```
Okay, sounds good then.
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (0579e62).