Make some CSS selectors more specific to avoid style bleed into descendents.
Review Request #4492 — Created Aug. 27, 2013 and submitted
Make some CSS selectors more specific to avoid style bleed into descendents. The list of replies to a comment on the review request page are arranged semantically, using ul>li. Unfortunately, the reply-comments style bled through to *all* li descendants of the top-level list, and not just immediate children. This meant that when markdown formatting used a list (for actual lists, or the way that it formats code samples), it would have all the junk used to display the replies. Similarly, a couple of the elements inside the change description banners at the top of the page had loose selectors which caused styles to bleed into the <pre> unnecessarily.
Saw that lists inside the .reviewtext and change description elements didn't inherit a bunch of junky styles.
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: Ignored Files: reviewboard/static/rb/css/reviews.less
- Change Summary:
-
Make this more generic, to catch a number of other, similar issues with change descriptions.
- Summary:
-
Change ".reply-comments li" to ".reply-comments>li"Make some CSS selectors more specific to avoid style bleed into descendents.
- Description:
-
~ Change ".reply-comments li" to ".reply-comments>li"
~ Make some CSS selectors more specific to avoid style bleed into descendents.
The list of replies to a comment on the review request page are arranged
semantically, using ul>li. Unfortunately, the reply-comments style bled through to all li descendants of the top-level list, and not just immediate children. This meant that when markdown formatting used a list (for actual lists, or the way that it formats code samples), it would have all the junk used to display the replies. + + Similarly, a couple of the elements inside the change description banners at
+ the top of the page had loose selectors which caused styles to bleed into the + <pre> unnecessarily. - Testing Done:
-
~ Saw that lists inside the .reviewtext elements didn't inherit a bunch of junky
~ styles. ~ Saw that lists inside the .reviewtext and change description elements didn't
~ inherit a bunch of junky styles.
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: Ignored Files: reviewboard/static/rb/css/reviews.less reviewboard/static/rb/css/common.less
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: Ignored Files: reviewboard/static/rb/css/reviews.less