2: IE6 - Review request - claims broken page

cae***@gmai***** (Google Code) (Is this you? Claim this profile.)
March 30, 2007
What's the URL of the page containing the problem?
http://osiris.chipx86.com:8080/reviews/3/

What steps will reproduce the problem?
1. Go there in IE6

What is the expected output? What do you see instead?
The edit fields don't work. (Cannot edit them)

Error output:
Line 173 char 3
Expected identifier, string, or number
Code:0

Since this is in the javascript, I suspect this is why the edit fields
don't work.
#1 cae***@gmai***** (Google Code) (Is this you? Claim this profile.)
'Discard' doesn't work, likely also because of javascript disagreements.
(Set submitted and Upload diff work fine, but do not seek to put a green box up top
normally either)
#2 cae***@gmai***** (Google Code) (Is this you? Claim this profile.)
Weird trivia:
When you go to the same url with /# added to the end, IE6 claims to see no errors but
still doesn't show the page any differently.
#3 cae***@gmai***** (Google Code) (Is this you? Claim this profile.)
function registerEditor(field, multiline) {
		var editor = new RB.widgets.InlineEditor({
			el: field,
			multiline: multiline,
			cls: field + '-editor',
			showEditIcon: true,                 <---- this line. (173)
		});

trailing comma that makes IE6 cry.
#4 cae***@gmai***** (Google Code) (Is this you? Claim this profile.)
This is also going to break on line 186 for the same reason.
#5 cae***@gmai***** (Google Code) (Is this you? Claim this profile.)
THIS IS FIXED.
#6 cae***@gmai***** (Google Code) (Is this you? Claim this profile.)
  • +Verified