Summary

Patch: Allow Mercurial (hg) scmtools back end to utilize repository credentials when accessing HTTP/HTTPS paths

Review Request #448 — Created July 10, 2008 and submitted

Information

Owner

derek

Repository

Review Board SVN (deprecated)

Branch

Bugs

536

Depends On

Reviewers

Groups

reviewboard

People

Description

A relatively simple change that seems to work ... that said, I don't really know Python at all, so it's rather likely that there's something "not quite right" here.

Testing Done

Tested on Debian and Windows, Python 2.5.2. It also seems to work alright with unauthenticated remote servers, though that has only been tested lightly.

trunk/reviewboard/scmtools/hg.py (Diff revision 1)

What if the username and/or password are blank? Maybe we should only do this if one or both are set.

derek July 10, 2008, 5:14 p.m.

I thought that would be problematic as well, but it didn't complain on the add_password call when they were blank in my testing. For unauthenticated repositories, the password manager is never consulted, so it appears to be harmless.

Ship it!

In that case, this looks good.  Committed as r1401.  Thanks!