Add review UIs to the diff viewer.
Review Request #4479 — Created Aug. 22, 2013 and submitted
Add review UIs to the diff viewer. We now display review UIs in the diff viewer for file attachments that have an inline-capable review UI. This takes the place of the thumbnail that we would otherwise render. When displaying an inline-capable review UI, the "Review" button goes away, and the review UI is just rendered inline. It can be commented on, just like normal. At the moment, both the original and modified versions each have a review UI capable of commenting. It's unclear whether the left-hand side should allow commenting on a review UI, but right now, it's there. Extra work would need to be done to tell the AbstractReviewables that they're not allowed to add commenting capabilities. The next step is to add diffable file attachment support to review UIs.
Tested with some image files with the ImageReviewUI.allow_inline = True. I was able to comment on the images. Reloading the page didn't cache the old comment data, so I saw my new comments. They appeared in the review. Tested with allow_inline = False, and it went to the previous behavior of having a Review link, and just showing thumbnails.
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/diffviewer/renderers.py reviewboard/reviews/ui/image.py reviewboard/reviews/templatetags/reviewtags.py reviewboard/diffviewer/diffutils.py reviewboard/attachments/tests.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/templates/diffviewer/diff_file_fragment.html reviewboard/static/rb/css/reviews.less reviewboard/templates/reviews/ui/default.html reviewboard/attachments/templatetags/attachments.py reviewboard/templates/reviews/ui/base_inline.html reviewboard/static/rb/js/views/imageReviewableView.js -
-
- Change Summary:
-
Added missing imports for exceptions.
- Diff:
-
Revision 2 (+145 -89)
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/diffviewer/renderers.py reviewboard/reviews/ui/image.py reviewboard/reviews/templatetags/reviewtags.py reviewboard/diffviewer/diffutils.py reviewboard/attachments/tests.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/templates/diffviewer/diff_file_fragment.html reviewboard/static/rb/css/reviews.less reviewboard/templates/reviews/ui/default.html reviewboard/attachments/templatetags/attachments.py reviewboard/templates/reviews/ui/base_inline.html reviewboard/static/rb/js/views/imageReviewableView.js
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/diffviewer/renderers.py reviewboard/reviews/ui/image.py reviewboard/reviews/templatetags/reviewtags.py reviewboard/diffviewer/diffutils.py reviewboard/attachments/tests.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/templates/diffviewer/diff_file_fragment.html reviewboard/static/rb/css/reviews.less reviewboard/templates/reviews/ui/default.html reviewboard/attachments/templatetags/attachments.py reviewboard/templates/reviews/ui/base_inline.html reviewboard/static/rb/js/views/imageReviewableView.js
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/diffviewer/renderers.py reviewboard/reviews/ui/image.py reviewboard/reviews/templatetags/reviewtags.py reviewboard/diffviewer/diffutils.py reviewboard/attachments/tests.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/templates/diffviewer/diff_file_fragment.html reviewboard/static/rb/css/reviews.less reviewboard/templates/reviews/ui/default.html reviewboard/attachments/templatetags/attachments.py reviewboard/templates/reviews/ui/base_inline.html reviewboard/static/rb/js/views/imageReviewableView.js