Fix alignment of the file attachment thumbnail overlay.

Review Request #4475 — Created Aug. 21, 2013 and submitted

Information

Review Board
release-1.7.x

Reviewers

Fix alignment of the file attachment thumbnail overlay.

We put a clickable overlay on top of file attachment thumbnails, to ensure that
clicking anywhere within the area of the attachment will redirect to the review
UI (instead of selecting text or accidentally activating any links that might
be part of the thumbnail, e.g. for text file types). This overlay wasn't set to
have a left alignment of 0, so its left edge was aligned with the thumbnail
itself. This worked for some types (like text) but failed when we had
thumbnails that didn't stretch the full width of the box.
Verified alignment in Chrome and Firefox.
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/css/reviews.less
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/css/reviews.less
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (36eaa7c).
Loading...