Summary

Fix up pep-8 issues in some more apps directories.

Review Request #4473 — Created Aug. 26, 2013 and submitted Aug. 27, 2013, 3:59 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Fix up pep-8 issues in some more apps directories.

This fixes up many of the pep8 issues in the extensions, hostingsvcs,
notifications, and reviews directories.

Testing Done

Issues

Description	From	Last Updated
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Aug. 26, 2013, 12:25 a.m.
'ReviewRequest' imported but unused	reviewbot	Aug. 26, 2013, 1:59 p.m.
'InvalidChangeNumberError' imported but unused	reviewbot	Aug. 26, 2013, 1:59 p.m.
'ChangeNumberInUseError' imported but unused	reviewbot	Aug. 26, 2013, 1:59 p.m.
'ChangeSetError' imported but unused	reviewbot	Aug. 26, 2013, 1:59 p.m.
'SCMError' imported but unused	reviewbot	Aug. 26, 2013, 1:59 p.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	Aug. 26, 2013, 2:05 p.m.
'DIFF_EMPTY' imported but unused	reviewbot	Aug. 26, 2013, 2:12 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/management/commands/fixreviewcounts.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/datagrids.py
    reviewboard/hostingsvcs/github.py
    reviewboard/reviews/management/commands/index.py
    reviewboard/reviews/ui/base.py
    reviewboard/reviews/management/commands/fill-database.py
    reviewboard/hostingsvcs/codebasehq.py
    reviewboard/extensions/tests.py
    reviewboard/reviews/models.py
    reviewboard/reviews/ui/__init__.py
    reviewboard/extensions/hooks.py
    reviewboard/reviews/evolutions/review_request_last_review_activity_timestamp.py
    reviewboard/reviews/managers.py
    reviewboard/reviews/tests.py
    reviewboard/reviews/urls.py
    reviewboard/reviews/evolutions/file_attachments.py
    reviewboard/hostingsvcs/service.py
    reviewboard/extensions/templatetags/rb_extensions.py
    reviewboard/notifications/email.py
    reviewboard/reviews/evolutions/change_descriptions.py
    reviewboard/reviews/evolutions/add_issues_to_comments.py
    reviewboard/hostingsvcs/tests.py
    reviewboard/notifications/tests.py
    reviewboard/reviews/evolutions/localsite.py
    reviewboard/reviews/admin.py
    reviewboard/reviews/forms.py
    reviewboard/extensions/base.py
  Ignored Files:

reviewboard/hostingsvcs/tests.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/management/commands/fixreviewcounts.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/datagrids.py
    reviewboard/hostingsvcs/github.py
    reviewboard/reviews/management/commands/index.py
    reviewboard/reviews/ui/base.py
    reviewboard/reviews/management/commands/fill-database.py
    reviewboard/hostingsvcs/codebasehq.py
    reviewboard/extensions/tests.py
    reviewboard/reviews/models.py
    reviewboard/reviews/ui/__init__.py
    reviewboard/extensions/hooks.py
    reviewboard/reviews/evolutions/review_request_last_review_activity_timestamp.py
    reviewboard/reviews/managers.py
    reviewboard/reviews/tests.py
    reviewboard/reviews/urls.py
    reviewboard/reviews/evolutions/file_attachments.py
    reviewboard/hostingsvcs/service.py
    reviewboard/extensions/templatetags/rb_extensions.py
    reviewboard/notifications/email.py
    reviewboard/reviews/evolutions/change_descriptions.py
    reviewboard/reviews/evolutions/add_issues_to_comments.py
    reviewboard/hostingsvcs/tests.py
    reviewboard/notifications/tests.py
    reviewboard/reviews/evolutions/localsite.py
    reviewboard/reviews/admin.py
    reviewboard/reviews/forms.py
    reviewboard/extensions/base.py
  Ignored Files:

reviewboard/reviews/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'ReviewRequest' imported but unused
```
reviewboard/reviews/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'InvalidChangeNumberError' imported but unused
```
reviewboard/reviews/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'ChangeNumberInUseError' imported but unused
```
reviewboard/reviews/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'ChangeSetError' imported but unused
```
reviewboard/reviews/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'SCMError' imported but unused
```

Diff:

Revision 2 (+1344 -1063)

Show changes

	reviewboard/manage.py
	reviewboard/settings.py
	reviewboard/urls.py
	reviewboard/scmtools/bzr.py
	reviewboard/scmtools/clearcase.py
	reviewboard/scmtools/core.py
	reviewboard/scmtools/cvs.py
	reviewboard/scmtools/forms.py
	19 more

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/scmtools/tests.py
    reviewboard/scmtools/forms.py
    reviewboard/scmtools/cvs.py
    reviewboard/scmtools/perforce_vmware.py
    reviewboard/site/tests.py
    reviewboard/ssh/errors.py
    reviewboard/scmtools/bzr.py
    reviewboard/webapi/encoder.py
    reviewboard/scmtools/core.py
    reviewboard/site/models.py
    reviewboard/scmtools/management/commands/registerscmtools.py
    reviewboard/scmtools/svn.py
    reviewboard/scmtools/clearcase.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/localfile.py
    reviewboard/webapi/errors.py
    reviewboard/scmtools/plastic.py
    reviewboard/scmtools/perforce.py
    reviewboard/webapi/decorators.py
    reviewboard/urls.py
    reviewboard/manage.py
    reviewboard/settings.py
    reviewboard/webapi/resources.py
    reviewboard/ssh/utils.py
    reviewboard/scmtools/git.py
    reviewboard/scmtools/hg.py
    reviewboard/webapi/tests.py
  Ignored Files:

reviewboard/scmtools/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/scmtools/tests.py
    reviewboard/scmtools/forms.py
    reviewboard/scmtools/cvs.py
    reviewboard/scmtools/perforce_vmware.py
    reviewboard/site/tests.py
    reviewboard/ssh/errors.py
    reviewboard/scmtools/bzr.py
    reviewboard/webapi/encoder.py
    reviewboard/scmtools/core.py
    reviewboard/site/models.py
    reviewboard/scmtools/management/commands/registerscmtools.py
    reviewboard/scmtools/svn.py
    reviewboard/scmtools/clearcase.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/localfile.py
    reviewboard/webapi/errors.py
    reviewboard/scmtools/plastic.py
    reviewboard/scmtools/perforce.py
    reviewboard/webapi/decorators.py
    reviewboard/urls.py
    reviewboard/manage.py
    reviewboard/settings.py
    reviewboard/webapi/resources.py
    reviewboard/ssh/utils.py
    reviewboard/scmtools/git.py
    reviewboard/scmtools/hg.py
    reviewboard/webapi/tests.py
  Ignored Files:

reviewboard/webapi/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 'DIFF_EMPTY' imported but unused
```

Diff:

Revision 3 (+1344 -1063)

Show changes

	reviewboard/manage.py
	reviewboard/settings.py
	reviewboard/urls.py
	reviewboard/scmtools/bzr.py
	reviewboard/scmtools/clearcase.py
	reviewboard/scmtools/core.py
	reviewboard/scmtools/cvs.py
	reviewboard/scmtools/forms.py
	19 more

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/scmtools/tests.py
    reviewboard/scmtools/forms.py
    reviewboard/scmtools/cvs.py
    reviewboard/scmtools/perforce_vmware.py
    reviewboard/site/tests.py
    reviewboard/ssh/errors.py
    reviewboard/scmtools/bzr.py
    reviewboard/webapi/encoder.py
    reviewboard/scmtools/core.py
    reviewboard/site/models.py
    reviewboard/scmtools/management/commands/registerscmtools.py
    reviewboard/scmtools/svn.py
    reviewboard/scmtools/clearcase.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/localfile.py
    reviewboard/webapi/errors.py
    reviewboard/scmtools/plastic.py
    reviewboard/scmtools/perforce.py
    reviewboard/webapi/decorators.py
    reviewboard/urls.py
    reviewboard/manage.py
    reviewboard/settings.py
    reviewboard/webapi/resources.py
    reviewboard/ssh/utils.py
    reviewboard/scmtools/git.py
    reviewboard/scmtools/hg.py
    reviewboard/webapi/tests.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/scmtools/tests.py
    reviewboard/scmtools/forms.py
    reviewboard/scmtools/cvs.py
    reviewboard/scmtools/perforce_vmware.py
    reviewboard/site/tests.py
    reviewboard/ssh/errors.py
    reviewboard/scmtools/bzr.py
    reviewboard/webapi/encoder.py
    reviewboard/scmtools/core.py
    reviewboard/site/models.py
    reviewboard/scmtools/management/commands/registerscmtools.py
    reviewboard/scmtools/svn.py
    reviewboard/scmtools/clearcase.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/localfile.py
    reviewboard/webapi/errors.py
    reviewboard/scmtools/plastic.py
    reviewboard/scmtools/perforce.py
    reviewboard/webapi/decorators.py
    reviewboard/urls.py
    reviewboard/manage.py
    reviewboard/settings.py
    reviewboard/webapi/resources.py
    reviewboard/ssh/utils.py
    reviewboard/scmtools/git.py
    reviewboard/scmtools/hg.py
    reviewboard/webapi/tests.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (a99ef91).

reviewboard/webapi/tests.py (Diff revision 2)