Fix the "Open an issue" checkbox.

Review Request #4465 — Created Aug. 19, 2013 and submitted

Information

Review Board
master

Reviewers

Fix the "Open an issue" checkbox.

There were a handful of problems with the "open an issue" checkbox in the
comment dialog, mostly introduced when I marked the javascript strings for
translation:

- The form field used "name" instead of "id", which meant that clicking on
  the label didn't work.
- The "Open an issue" text has an underline on the "i", presumably to denote
  an access key, but it was formatted into the template with HTML escaping.
- The <label> element has an accesskey attribute that we weren't defining.
- Created new comments and edited old ones, changing the issue state.
- Verified that clicking on the label changed the state of the checkbox.
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/js/views/commentDialogView.js
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/js/views/commentDialogView.js
    
    
  2. 
      
chipx86
  1. Looks good, but you're missing Testing Done, which we should have for the records.
  2. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (9157b7d).
Loading...