• 
      

    Fix the RepositoryForm unit tests, and make them less error-prone.

    Review Request #4455 — Created Aug. 14, 2013 and submitted

    Information

    Review Board
    release-1.7.x

    Reviewers

    Fix the RepositoryForm unit tests, and make them less error-prone.
    
    My final work for the Bitbucket support broke RepositoryForm unit tests,
    and I apparently failed to test those. So, this change fixes it, by
    making use of a TestService instead of using an existing hosting service
    for tests. This way, we can control things like authorization (which is
    what broke the tests before), repository checking, fields, etc.
    All unit tests pass.
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
          reviewboard/scmtools/tests.py
        Ignored Files:
      
      
    2. 
        
    reviewbot
    1. This is a review from Review Bot.
        Tool: Pyflakes
        Processed Files:
          reviewboard/scmtools/tests.py
        Ignored Files:
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed