Summary

RBTools clean-up

Review Request #4449 — Created Aug. 13, 2013 and submitted Aug. 14, 2013, 1:37 p.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

RBTools clean-up

This change cleans up a lot of the code to fix trailing whitespace and PEP-8
issues.

Testing Done

Ran tests. No more failed than before.

Issues

Description	From	Last Updated
Blank line after this.	chipx86	Aug. 14, 2013, 12:35 p.m.
I don't know why there's an 'r' on this, but it doesn't need to be here.	chipx86	Aug. 14, 2013, 12:35 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    rbtools/postreview.py
    rbtools/clients/tests.py
    rbtools/api/tests.py
    rbtools/commands/api_get.py
    rbtools/api/factory.py
    rbtools/commands/post.py
    rbtools/commands/__init__.py
    rbtools/clients/clearcase.py
    rbtools/clients/plastic.py
    rbtools/clients/bazaar.py
    rbtools/clients/git.py
    rbtools/clients/perforce.py
    rbtools/clients/mercurial.py
    rbtools/clients/svn.py
    rbtools/tests.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    rbtools/postreview.py
    rbtools/clients/tests.py
    rbtools/api/tests.py
    rbtools/commands/api_get.py
    rbtools/api/factory.py
    rbtools/commands/post.py
    rbtools/commands/__init__.py
    rbtools/clients/clearcase.py
    rbtools/clients/plastic.py
    rbtools/clients/bazaar.py
    rbtools/clients/git.py
    rbtools/clients/perforce.py
    rbtools/clients/mercurial.py
    rbtools/clients/svn.py
    rbtools/tests.py
  Ignored Files:

rbtools/clients/mercurial.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line after this.
```
rbtools/clients/mercurial.py (Diff revision 1)
The issue has been resolved. Show all issues
```
I don't know why there's an 'r' on this, but it doesn't need to be here.
```

Diff:

Revision 2 (+201 -203)

Show changes

	rbtools/postreview.py
	rbtools/tests.py
	rbtools/api/factory.py
	rbtools/api/tests.py
	rbtools/clients/bazaar.py
	rbtools/clients/clearcase.py
	rbtools/clients/git.py
	rbtools/clients/mercurial.py
	7 more

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    rbtools/postreview.py
    rbtools/clients/tests.py
    rbtools/api/tests.py
    rbtools/commands/api_get.py
    rbtools/api/factory.py
    rbtools/commands/post.py
    rbtools/commands/__init__.py
    rbtools/clients/clearcase.py
    rbtools/clients/plastic.py
    rbtools/clients/bazaar.py
    rbtools/clients/git.py
    rbtools/clients/perforce.py
    rbtools/clients/mercurial.py
    rbtools/clients/svn.py
    rbtools/tests.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    rbtools/postreview.py
    rbtools/clients/tests.py
    rbtools/api/tests.py
    rbtools/commands/api_get.py
    rbtools/api/factory.py
    rbtools/commands/post.py
    rbtools/commands/__init__.py
    rbtools/clients/clearcase.py
    rbtools/clients/plastic.py
    rbtools/clients/bazaar.py
    rbtools/clients/git.py
    rbtools/clients/perforce.py
    rbtools/clients/mercurial.py
    rbtools/clients/svn.py
    rbtools/tests.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (99ba381).