Summary

Fix compatibility with Python 2.5

Review Request #4433 — Created Aug. 13, 2013 and submitted Aug. 13, 2013, 2:11 p.m.

Information

Owner

david

Repository

Djblets

Branch

master

Bugs

2935

Depends On

Reviewers

Groups

djblets

People

Description

Fix compatibility with Python 2.5

Our controlled_subprocess context manager used Popen.kill, which is only
available in Python 2.6. Additionally, os.kill didn't gain windows
compatibility until 2.7, so we're stuck having to do some kind of gross things
to kill the process.

Testing Done

Expand All
Collapse All

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    djblets/util/contextmanagers.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    djblets/util/contextmanagers.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to djblets master (7d45fb5).