• 
      

    Fix "From" field in emails for --submit-as

    Review Request #4418 — Created Aug. 11, 2013 and submitted

    Information

    Review Board
    master

    Reviewers

    Fix "From" field in emails for --submit-as
    
    When sending emails for review requests, reviews, and replies, we'd send it
    from the request user, rather than the owner of the relevant object. This made
    using --submit-as pretty ugly.
    
    At some point in the future, we want to enable many users to collaborate on the
    same review request, at which point we'll have to revisit this, but for now,
    fix the bugs.
    
    Ran unit tests
    
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
          reviewboard/notifications/email.py
        Ignored Files:
      
      
    2. 
        
    reviewbot
    1. This is a review from Review Bot.
        Tool: Pyflakes
        Processed Files:
          reviewboard/notifications/email.py
        Ignored Files:
      
      
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-1.7.x (8cc0f4d).