Pass on base_commit_id to hosting services for file lookups.
Review Request #4415 — Created Aug. 10, 2013 and submitted
Pass on base_commit_id to hosting services for file lookups. The base_commit_id is now passed on to the get_file/get_file_exists functions in hosting services, so that they may make use of it when fetching file data. It's not passed on to SCMTools, since we currently have no need there, but it can be added later if needed. This, combined with some upcoming changes, will allow us to support services like Beanstalk and BitBucket for Git.
Unit tests pass. Tested manually with the upcoming Beanstalk change.
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/scmtools/models.py reviewboard/scmtools/hg.py reviewboard/scmtools/localfile.py reviewboard/scmtools/errors.py reviewboard/diffviewer/tests.py reviewboard/diffviewer/diffutils.py reviewboard/scmtools/tests.py reviewboard/diffviewer/managers.py reviewboard/scmtools/svn.py Ignored Files: -
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/scmtools/models.py reviewboard/scmtools/hg.py reviewboard/scmtools/localfile.py reviewboard/scmtools/errors.py reviewboard/diffviewer/tests.py reviewboard/diffviewer/diffutils.py reviewboard/scmtools/tests.py reviewboard/diffviewer/managers.py reviewboard/scmtools/svn.py Ignored Files:
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/scmtools/models.py reviewboard/scmtools/hg.py reviewboard/scmtools/localfile.py reviewboard/scmtools/errors.py reviewboard/diffviewer/tests.py reviewboard/diffviewer/diffutils.py reviewboard/scmtools/tests.py reviewboard/diffviewer/managers.py reviewboard/scmtools/svn.py Ignored Files:
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/scmtools/models.py reviewboard/scmtools/hg.py reviewboard/scmtools/localfile.py reviewboard/scmtools/errors.py reviewboard/diffviewer/tests.py reviewboard/diffviewer/diffutils.py reviewboard/scmtools/tests.py reviewboard/diffviewer/managers.py reviewboard/scmtools/svn.py Ignored Files: