Summary

Pass request object to auth backends' get_or_create_user() methods.

Review Request #4403 — Created Aug. 7, 2013 and submitted Aug. 16, 2013, 10:40 a.m.

Information

Owner

mcote

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

smacleod

Description

Pass request object to auth backends' get_or_create_user() methods.

Testing Done

All unit tests pass: 

----------------------------------------------------------------------
Ran 703 tests in 132.756s

OK (SKIP=12)

The skipped tests are all related to perforce, which I don't have installed.  They should be unrelated to my patch.

People:: smacleod

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/accounts/backends.py
    reviewboard/webapi/resources.py
  Ignored Files:

This looks fine. I'd like to see something in Testing Done. Can you verify that unit tests pass?

Testing Done:: +
All unit tests pass:
+
+
+
+
Ran 703 tests in 132.756s
+
+
OK (SKIP=12)
+
+
The skipped tests are all related to perforce, which I don't have installed. They should be unrelated to my patch.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.7.x (78234a1). Thanks!

	+	All unit tests pass:
	+
	+
	+
	+	Ran 703 tests in 132.756s
	+
	+	OK (SKIP=12)
	+
	+	The skipped tests are all related to perforce, which I don't have installed. They should be unrelated to my patch.