Summary

Add a field to DiffSet for storing the commit ID a change is based on.

Review Request #4397 — Created Aug. 5, 2013 and submitted Aug. 10, 2013, 4:16 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Add a field to DiffSet for storing the commit ID a change is based on.

This field can be set when uploading a diff via the API. We can make use
of it for certain hosting services that only provide file fetching APIs
that take Git commit SHA1s instead of blob SHA1s.

The field is optional. RBTools will be updated to set it for Git, but it
will otherwise be used only as needed.

This will be backported to release-1.7.x, but some work needs to be done.
(The tests we modify, for instance, don't exist there.)

Testing Done

Posted with an accompanying RBTools change, and saw the commit ID in the
database.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/webapi/resources.py
    reviewboard/diffviewer/models.py
    reviewboard/diffviewer/tests.py
    reviewboard/webapi/tests.py
    reviewboard/diffviewer/evolutions/__init__.py
    reviewboard/diffviewer/forms.py
    reviewboard/diffviewer/managers.py
    reviewboard/diffviewer/evolutions/diffset_base_commit_id.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/webapi/resources.py
    reviewboard/diffviewer/models.py
    reviewboard/diffviewer/tests.py
    reviewboard/webapi/tests.py
    reviewboard/diffviewer/evolutions/__init__.py
    reviewboard/diffviewer/forms.py
    reviewboard/diffviewer/managers.py
    reviewboard/diffviewer/evolutions/diffset_base_commit_id.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status:: Completed