• 
      

    Fix default value for HostingService._http_request headers parameter

    Review Request #4392 — Created Aug. 5, 2013 and submitted

    Information

    Review Board
    master

    Reviewers

    Fix default value for HostingService._http_request headers parameter
    
    The default value for the 'headers' parameter to the _http_request was None,
    which meant that if something called it without passing in headers,
    urllib2.Request()'s constructor would throw an exception. Other similar code
    uses a default value of an empty dictionary, which is more appropriate.
    
     
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
          reviewboard/hostingsvcs/service.py
        Ignored Files:
      
      
    2. 
        
    reviewbot
    1. This is a review from Review Bot.
        Tool: Pyflakes
        Processed Files:
          reviewboard/hostingsvcs/service.py
        Ignored Files:
      
      
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (3f9ba84).