Prompt user to continue when there is a uncommitted diff.
Review Request #4390 — Created Aug. 5, 2013 and discarded
Sometimes the user may forget to commit the change before putting a patch to revision, which end up being a empty revision, which is confusing. This patch gives user a warning when there is a uncommitted diff by asking if he/she really wants to continue.
Test with both dirty branch and clean branch, works fine.
Description | From | Last Updated |
---|---|---|
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot | |
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot | |
Col: 19 E231 missing whitespace after ':' |
reviewbot | |
Col: 31 E231 missing whitespace after ':' |
reviewbot | |
Col: 43 E231 missing whitespace after ':' |
reviewbot | |
Col: 25 E241 multiple spaces after ',' |
reviewbot | |
Col: 37 E241 multiple spaces after ',' |
reviewbot | |
Col: 18 E231 missing whitespace after ':' |
reviewbot | |
Col: 33 E231 missing whitespace after ':' |
reviewbot | |
Col: 25 E241 multiple spaces after ',' |
reviewbot | |
Col: 16 E711 comparison to None should be 'if cond is None:' |
reviewbot | |
Col: 66 E502 the backslash is redundant between brackets |
reviewbot | |
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot | |
This should probably check sys.__stdin__.isatty() and just automatically make a decision without any output in the case where python is … |
david | |
This should probably use distutils.util.strtobool instead of rolling it yourself. |
david | |
These should still be broken up into two groups (one group for standard library modules, and one for rbtools). They … |
david | |
Please capitalize "Invalid" |
david | |
Please move this block to come first--there's no reason to define the prompt if we never use it. |
david | |
raw_input will print a prompt, so this can be condensed to: choice = raw_input(question + prompt).lower() |
david | |
Hmm. So make_diff is only defined in the git client, which means I think this will explode for anything not … |
david |
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: rbtools/postreview.py rbtools/utils/users.py Ignored Files:
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: rbtools/postreview.py rbtools/utils/users.py Ignored Files:
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: rbtools/postreview.py rbtools/utils/users.py Ignored Files:
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: rbtools/postreview.py rbtools/utils/users.py Ignored Files:
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: rbtools/postreview.py rbtools/utils/users.py Ignored Files:
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: rbtools/postreview.py rbtools/utils/users.py Ignored Files:
-
-
These should still be broken up into two groups (one group for standard library modules, and one for rbtools). They should also be sorted alphabetically, so the distutils line should come first.
-
-
-
raw_input will print a prompt, so this can be condensed to: choice = raw_input(question + prompt).lower()
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: rbtools/postreview.py rbtools/utils/users.py Ignored Files:
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: rbtools/postreview.py rbtools/utils/users.py Ignored Files:
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: rbtools/postreview.py rbtools/utils/users.py Ignored Files:
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: rbtools/postreview.py rbtools/utils/users.py Ignored Files: