Summary

Move the CommentBarIssueView creation code into ReviewBoxView.

Review Request #4381 — Created Aug. 2, 2013 and submitted Aug. 3, 2013, 3:14 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Move the CommentBarIssueView creation code into ReviewBoxView.

The code to create a CommentBarIssueView was being done inside the
template for the page, adding more script tags and more document.ready
calls.

This code is now created when rendering the ReviewBoxView. It creates
based on data attributes now stored on the element. It's part of an
effort to remove <script> tags in the templates, which will help with
the require.js migration.

Testing Done

Tested loading comments without issues, and comments with. That's with
and without a logged in user.

Tested changing issue state.

Issues

Description	From	Last Updated
So {{interactive}} is theoretically a boolean, but what we get from .data is a string. Can you convert explicitly?	david	Aug. 2, 2013, 11:39 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    reviewboard/templates/reviews/review_detail.html
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/views/reviewBoxView.js
    reviewboard/templates/reviews/comment_issue.html

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
  Ignored Files:
    reviewboard/templates/reviews/review_detail.html
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/views/reviewBoxView.js
    reviewboard/templates/reviews/comment_issue.html

reviewboard/static/rb/js/views/reviewBoxView.js (Diff revision 1)

The issue has been dropped. Show all issues

So {{interactive}} is theoretically a boolean, but what we get from .data is a string. Can you convert explicitly?

chipx86 Aug. 2, 2013, 11:40 p.m.

jQuery is smart and does this for us. It also converts "123" to 123.

(I actually forgot at first and did a comparison against "true", and it was broken.)

Ship it!

```
Ship It!
```

Status:: Completed