Summary

Allow commenters to change the status of the issues they open.

Review Request #4380 — Created Aug. 2, 2013 and submitted Aug. 5, 2013, 4:58 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

2713, 2888

Depends On

Reviewers

Groups

reviewboard

People

Description

Allow commenters to change the status of the issues they open.

Until now, only the owner of a review request could change the status of an
issue. A frequently recurring request is to allow the person who originally
opened the comment to do the same--especially to be able to reopen it.

This is an update of Niklas Hambuechen's change at
https://reviews.reviewboard.org/r/3837/

I've updated it to address the original concerns with that change, as well as
streamlined a lot of the code.

Testing Done

- Ran unit tests.
- Verified that the "interactive" parameter in the template was correct.

Issues

Description	From	Last Updated
Col: 17 E201 whitespace after '('	reviewbot	Aug. 2, 2013, 6:28 p.m.
Col: 17 E128 continuation line under-indented for visual indent	reviewbot	Aug. 2, 2013, 6:28 p.m.
This will now conflict with my change that's up, but it should be an easy fix.	chipx86	Aug. 3, 2013, 3:47 p.m.
Col: 80 E501 line too long (110 > 79 characters)	reviewbot	Aug. 2, 2013, 6:28 p.m.
Col: 80 E501 line too long (129 > 79 characters)	reviewbot	Aug. 2, 2013, 6:28 p.m.
Col: 80 E501 line too long (128 > 79 characters)	reviewbot	Aug. 2, 2013, 6:28 p.m.
Col: 80 E501 line too long (117 > 79 characters)	reviewbot	Aug. 2, 2013, 6:28 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Aug. 2, 2013, 6:28 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Aug. 2, 2013, 6:29 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Aug. 2, 2013, 6:29 p.m.
Col: 80 E501 line too long (123 > 79 characters)	reviewbot	Aug. 2, 2013, 6:29 p.m.
Col: 80 E501 line too long (135 > 79 characters)	reviewbot	Aug. 2, 2013, 6:29 p.m.
Col: 80 E501 line too long (134 > 79 characters)	reviewbot	Aug. 2, 2013, 6:29 p.m.
Col: 80 E501 line too long (123 > 79 characters)	reviewbot	Aug. 2, 2013, 6:29 p.m.
Col: 80 E501 line too long (128 > 79 characters)	reviewbot	Aug. 2, 2013, 6:29 p.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	Aug. 2, 2013, 6:29 p.m.
Col: 80 E501 line too long (110 > 79 characters)	reviewbot	Aug. 3, 2013, 4:04 p.m.
Col: 80 E501 line too long (129 > 79 characters)	reviewbot	Aug. 3, 2013, 4:04 p.m.
Col: 80 E501 line too long (128 > 79 characters)	reviewbot	Aug. 3, 2013, 4:04 p.m.
Col: 80 E501 line too long (117 > 79 characters)	reviewbot	Aug. 3, 2013, 4:04 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Aug. 3, 2013, 4:04 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Aug. 3, 2013, 4:04 p.m.
Col: 80 E501 line too long (123 > 79 characters)	reviewbot	Aug. 3, 2013, 4:04 p.m.
Col: 80 E501 line too long (135 > 79 characters)	reviewbot	Aug. 3, 2013, 4:04 p.m.
Col: 80 E501 line too long (134 > 79 characters)	reviewbot	Aug. 3, 2013, 4:04 p.m.
Col: 80 E501 line too long (123 > 79 characters)	reviewbot	Aug. 3, 2013, 4:04 p.m.
Col: 80 E501 line too long (128 > 79 characters)	reviewbot	Aug. 3, 2013, 4:04 p.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	Aug. 3, 2013, 4:04 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/webapi/tests.py
    reviewboard/webapi/resources.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/models.py
  Ignored Files:
    reviewboard/templates/reviews/comment_issue.html

reviewboard/reviews/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 17
 E201 whitespace after '('
```
reviewboard/reviews/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 17
 E128 continuation line under-indented for visual indent
```
reviewboard/webapi/tests.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (110 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (129 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (128 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (117 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (123 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (135 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (134 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (123 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (128 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/webapi/tests.py
    reviewboard/webapi/resources.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/models.py
  Ignored Files:
    reviewboard/templates/reviews/comment_issue.html

reviewboard/reviews/models.py (Diff revision 1)

So, I'm going back and forth on this form. There are times I'm okay with it, and times it annoys me. Using it will annoy ReviewBot every time, though, and I've never seen other Python code do it.

PEP-8 discusses the case of:

if (self.get_review_request... or
    user == self.get_review...):
    bah

and how that looks wrong (except their example is using a def statement). They show:

if (self.get_review_request... or
        user == self.get_review...):
    bah

Which I'm not sure actually looks much better, but it'd keep ReviewBot happy.

http://www.python.org/dev/peps/pep-0008/#indentation

Bah.

david Aug. 3, 2013, 3:47 p.m.

I changed it to be the first one, which pep8 is happy with, and in this case it's not that bad since there's no block after it to get confused by.

reviewboard/templates/reviews/comment_issue.html (Diff revision 1)
The issue has been resolved. Show all issues
```
This will now conflict with my change that's up, but it should be an easy fix.
```
1. chipx86 Aug. 3, 2013, 3:36 p.m.
  Rather, my committed change.

Diff:

Revision 2 (+193 -171)

Show changes

	reviewboard/reviews/models.py
	reviewboard/reviews/templatetags/reviewtags.py
	reviewboard/templates/reviews/comment_issue.html
	reviewboard/webapi/resources.py
	reviewboard/webapi/tests.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/webapi/tests.py
    reviewboard/webapi/resources.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/models.py
  Ignored Files:
    reviewboard/templates/reviews/comment_issue.html

reviewboard/webapi/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (110 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (129 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (128 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (117 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (123 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (135 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (134 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (123 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (128 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/webapi/tests.py
    reviewboard/webapi/resources.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/models.py
  Ignored Files:
    reviewboard/templates/reviews/comment_issue.html

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (d0ff70d).