Add views and tests for a repository selector.
Review Request #4353 — Created July 21, 2013 and submitted
Add views and tests for a repository selector. This change adds views to show a collection of RB.Repository models in HTML suitable for the new review request UI. This is plumbed through so that the view will emit a 'selected' event and toggle element classes when the user clicks on any individual repository in the list.
- Ran unit tests. - Used this in my new review request UI.
| Description | From | Last Updated | ||
|---|---|---|---|---|
|
Col: 80 E501 line too long (81 > 79 characters) |
 reviewbot
|
|||
|
Docs? |
 chipx86
|
|||
|
Can you put a blank line after the parent call? Up to you, but I think it's nice to separate … |
chipx86
|
|||
|
Docs? |
chipx86
|
|||
|
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot
|
|||
| There are no open issues | ||||
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/settings.py Ignored Files: reviewboard/static/rb/js/newReviewRequest/views/repositoryView.js reviewboard/static/rb/js/newReviewRequest/views/tests/repositorySelectionViewTests.js reviewboard/static/rb/js/newReviewRequest/views/repositorySelectionView.js
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/settings.py Ignored Files: reviewboard/static/rb/js/newReviewRequest/views/repositoryView.js reviewboard/static/rb/js/newReviewRequest/views/tests/repositorySelectionViewTests.js reviewboard/static/rb/js/newReviewRequest/views/repositorySelectionView.js -
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/settings.py Ignored Files: reviewboard/static/rb/js/newReviewRequest/views/repositoryView.js reviewboard/static/rb/js/newReviewRequest/views/tests/repositorySelectionViewTests.js reviewboard/static/rb/js/newReviewRequest/views/repositorySelectionView.js
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/settings.py Ignored Files: reviewboard/static/rb/js/newReviewRequest/views/repositoryView.js reviewboard/static/rb/js/newReviewRequest/views/tests/repositorySelectionViewTests.js reviewboard/static/rb/js/newReviewRequest/views/repositorySelectionView.js