Summary

Add views and tests for a repository selector.

Review Request #4353 — Created July 21, 2013 and submitted July 23, 2013, 10:18 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Add views and tests for a repository selector.

This change adds views to show a collection of RB.Repository models in HTML
suitable for the new review request UI. This is plumbed through so that the view
will emit a 'selected' event and toggle element classes when the user clicks on
any individual repository in the list.

Testing Done

- Ran unit tests.
- Used this in my new review request UI.

Issues

Description	From	Last Updated
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	July 22, 2013, 10:15 a.m.
Docs?	chipx86	July 22, 2013, 10:09 a.m.
Can you put a blank line after the parent call? Up to you, but I think it's nice to separate …	chipx86	July 22, 2013, 10:09 a.m.
Docs?	chipx86	July 22, 2013, 10:09 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	July 22, 2013, 10:15 a.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/settings.py
  Ignored Files:
    reviewboard/static/rb/js/newReviewRequest/views/repositoryView.js
    reviewboard/static/rb/js/newReviewRequest/views/tests/repositorySelectionViewTests.js
    reviewboard/static/rb/js/newReviewRequest/views/repositorySelectionView.js

reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/settings.py
  Ignored Files:
    reviewboard/static/rb/js/newReviewRequest/views/repositoryView.js
    reviewboard/static/rb/js/newReviewRequest/views/tests/repositorySelectionViewTests.js
    reviewboard/static/rb/js/newReviewRequest/views/repositorySelectionView.js

reviewboard/static/rb/js/newReviewRequest/views/repositorySelectionView.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Docs?
```

reviewboard/static/rb/js/newReviewRequest/views/repositorySelectionView.js (Diff revision 1)

The issue has been resolved. Show all issues

Can you put a blank line after the parent call? Up to you, but I think it's nice to separate that.

reviewboard/static/rb/js/newReviewRequest/views/repositoryView.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Docs?
```

Diff:

Revision 2 (+134)

Show changes

	reviewboard/settings.py
	reviewboard/static/rb/js/newReviewRequest/views/repositorySelectionView.js
	reviewboard/static/rb/js/newReviewRequest/views/repositoryView.js
	reviewboard/static/rb/js/newReviewRequest/views/tests/repositorySelectionViewTests.js

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/settings.py
  Ignored Files:
    reviewboard/static/rb/js/newReviewRequest/views/repositoryView.js
    reviewboard/static/rb/js/newReviewRequest/views/tests/repositorySelectionViewTests.js
    reviewboard/static/rb/js/newReviewRequest/views/repositorySelectionView.js

reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/settings.py
  Ignored Files:
    reviewboard/static/rb/js/newReviewRequest/views/repositoryView.js
    reviewboard/static/rb/js/newReviewRequest/views/tests/repositorySelectionViewTests.js
    reviewboard/static/rb/js/newReviewRequest/views/repositorySelectionView.js

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (627c3a5).