Add a commit_id field to ReviewRequest
Review Request #4237 — Created June 12, 2013 and submitted — Latest diff uploaded
Add a commit_id field to ReviewRequest This change adds a new field called 'commit_id' to the ReviewRequest model. This field obsoletes the 'changenum' field. There's also a property called "commit" which will aggregate together the old "changenum" field and the new "commit_id" field. This new field is a 64-character string instead of an int, in order to handle SCMs that don't use numeric revisions (like git). Testing done: - Tested the migration with a database that had review requests with both null and non-null changenums - Ran unit tests - Did some smoke testing of various pieces of UI that deal with changenums Reviewed at http://reviews.reviewboard.org/r/4237/
- Tested the migration with a database that had review requests with both null and numeric changenum fields. - Ran unit tests. - Did some smoke testing of various pieces of UI that deal with changenums.
Diff Revision 4
This is not the most recent revision of the diff. The latest diff is revision 6. See what's changed.
orig
1
2
3
4
5
6
reviewboard/reviews/admin.py |
---|
reviewboard/reviews/forms.py |
---|
reviewboard/reviews/managers.py |
---|
reviewboard/reviews/models.py |
---|
reviewboard/reviews/tests.py |
---|
reviewboard/reviews/evolutions/__init__.py |
---|
reviewboard/reviews/evolutions/commit_id.py |
---|
reviewboard/templates/reviews/review_request_box.html |
---|
reviewboard/webapi/encoder.py |
---|
reviewboard/webapi/resources.py |
---|
reviewboard/webapi/tests.py |
---|